Skip to content

Conversation

@alarconesparza
Copy link
Contributor

@alarconesparza alarconesparza commented Jan 28, 2026

Description

Fixes internal b/470272226

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alarconesparza, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the pubsub publish-message function by upgrading its underlying Java version to 25. This upgrade necessitated a comprehensive update of several core dependencies and Maven plugins to ensure compatibility and to align with the latest development standards. The changes aim to improve the function's performance, security, and maintainability by leveraging newer language features and library improvements.

Highlights

  • Java Version Upgrade: The pubsub publish-message function's Java compiler target and source versions have been upgraded from Java 11 to Java 25.
  • Dependency Updates: Several key dependencies, including libraries-bom, functions-framework-api, truth, and mockito-core, have been updated to their latest compatible versions to ensure compatibility with Java 25 and leverage newer features.
  • Maven Plugin Upgrades: Maven plugins such as function-maven-plugin and maven-surefire-plugin have been updated to their latest versions.
  • New Plugin Introduction: The jacoco-maven-plugin has been added to the project, enabling code coverage reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on upgrading various dependencies and the Java compiler version for the pubsub publish-message function. Key updates include moving to Java 25, upgrading the shared-configuration parent POM, and updating several Google Cloud and testing libraries like libraries-bom, functions-framework-api, truth, and mockito-core. Additionally, the function-maven-plugin and maven-surefire-plugin have been updated, and the jacoco-maven-plugin has been introduced, which is a positive step for code coverage analysis. The changes align well with the pull request title and description.

<groupId>com.google.cloud.functions</groupId>
<artifactId>functions-framework-api</artifactId>
<version>1.1.0</version>
<version>2.0.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading functions-framework-api to version 2.0.0 is a major version bump. While the current function seems compatible, it's important to review the migration guide for functions-framework-api 2.0.0 to ensure there are no subtle breaking changes or recommended updates that should be applied to the function's implementation or its usage.

<groupId>com.google.cloud.functions</groupId>
<artifactId>function-maven-plugin</artifactId>
<version>0.11.0</version>
<version>1.0.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The function-maven-plugin has been upgraded to version 1.0.0. This is a major version release from 0.11.0. Please ensure that any migration steps or configuration changes required for this new major version have been addressed, even if the current configuration appears to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant