-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(functions): upgrade pubsub publish-message to Java 25 #10227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(functions): upgrade pubsub publish-message to Java 25 #10227
Conversation
Summary of ChangesHello @alarconesparza, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on upgrading various dependencies and the Java compiler version for the pubsub publish-message function. Key updates include moving to Java 25, upgrading the shared-configuration parent POM, and updating several Google Cloud and testing libraries like libraries-bom, functions-framework-api, truth, and mockito-core. Additionally, the function-maven-plugin and maven-surefire-plugin have been updated, and the jacoco-maven-plugin has been introduced, which is a positive step for code coverage analysis. The changes align well with the pull request title and description.
| <groupId>com.google.cloud.functions</groupId> | ||
| <artifactId>functions-framework-api</artifactId> | ||
| <version>1.1.0</version> | ||
| <version>2.0.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading functions-framework-api to version 2.0.0 is a major version bump. While the current function seems compatible, it's important to review the migration guide for functions-framework-api 2.0.0 to ensure there are no subtle breaking changes or recommended updates that should be applied to the function's implementation or its usage.
| <groupId>com.google.cloud.functions</groupId> | ||
| <artifactId>function-maven-plugin</artifactId> | ||
| <version>0.11.0</version> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes internal b/470272226
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only