Adds tracing sample for cloud spanner by vkedia · Pull Request #1002 · GoogleCloudPlatform/java-docs-samples

vkedia · 2018-01-23T00:45:07Z

bogdandrutu · 2018-01-23T00:46:38Z

spanner/cloud-client/pom.xml

+    <dependency>
+        <groupId>io.opencensus</groupId>
+        <artifactId>opencensus-api</artifactId>
+        <version>0.11.0</version>


Make it a variable because it is used in few places?

bogdandrutu · 2018-01-23T00:48:03Z

spanner/cloud-client/pom.xml

+    <dependency>
+        <groupId>io.opencensus</groupId>
+        <artifactId>opencensus-impl</artifactId>
+        <version>0.11.0</version>


<scope>runtime</scope>

bogdandrutu · 2018-01-23T00:50:25Z

spanner/cloud-client/src/main/java/com/example/spanner/TracingSample.java

+    ZPageHandlers.startHttpServerAndRegisterAll(8080);
+    // Installs an exporter for stack driver.
+    StackdriverExporter.createAndRegister();
+    Tracing.getExportComponent().getSampledSpanStore().registerSpanNamesForCollection(Arrays.asList("CloudSpannerSample"));


private static final String CLOUD_SPANNER_SAMPLE_SPAN_NAME = "CloudSpannerSample";

Not necessary the long suggested variable name but that will ensure that the string is the same here and 10 lines below.

bogdandrutu · 2018-01-23T00:51:40Z

Also you can install the StackdriverStatsExporter as well to push grpc stats to monitoring, here are instructions:
https://github.com/census-instrumentation/opencensus-java/tree/master/exporters/stats/stackdriver

lesv · 2018-01-23T01:04:30Z

You might wish to add something about this to the README.md

lesv · 2018-01-23T01:05:35Z

@rakyll Once they make the changes you've asked for, add the kokoro-forcerun label before accepting or merging.

bogdandrutu · 2018-01-23T01:32:02Z

If you link the stats you also need to define the views (or what data to export), to do that do the following:

Add a compilation dependency on io.opencensus:opencensus-contrib-grpc-metrics:0.11.0
In the main function call io.opencensus.contrib.grpc.metrics.RpcViews.registerAllCumulativeViews()

vkedia · 2018-01-23T17:39:05Z

Addressed all the comments. PTALA.
I am getting an exception while exporting stats:

Jan 23, 2018 9:30:04 AM io.opencensus.exporter.stats.stackdriver.StackdriverExporterWorker export
WARNING: ApiException thrown when exporting TimeSeries.
com.google.api.gax.rpc.UnavailableException: io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:69)
	at com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.setException(GrpcExceptionCallable.java:118)
	at com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:101)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:61)
	at com.google.common.util.concurrent.Futures$4.run(Futures.java:1123)
	at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:435)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:900)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:811)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:675)
	at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:492)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:467)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:41)
	at io.grpc.internal.CensusStatsModule$StatsClientInterceptor$1$1.onClose(CensusStatsModule.java:684)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:41)
	at io.grpc.internal.CensusTracingModule$TracingClientInterceptor$1$1.onClose(CensusTracingModule.java:392)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:475)
	at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:63)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:557)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$600(ClientCallImpl.java:478)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:590)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: io.grpc.StatusRuntimeException: UNAVAILABLE: io exception
	at io.grpc.Status.asRuntimeException(Status.java:526)
	... 19 more
Caused by: java.io.IOException: Operation timed out
	at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
	at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
	at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
	at sun.nio.ch.IOUtil.read(IOUtil.java:192)
	at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
	at io.netty.buffer.PooledUnsafeDirectByteBuf.setBytes(PooledUnsafeDirectByteBuf.java:288)
	at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1106)
	at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:343)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:123)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:645)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:580)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:497)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:459)
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
	... 1 more

vkedia · 2018-01-23T19:12:32Z

Enabling SD premium made it work.

vkedia · 2018-01-23T19:15:16Z

@lesv Can you please approve.

lesv · 2018-01-23T19:31:14Z

Waiting on Kokoro.

lesv

LGTM once kokoro is happy.

kurtisvg

Passed Kokoro and @lesv approved earlier

vkedia · 2018-01-23T21:19:36Z

Thanks!

🤖 I have created a release *beep* *boop* --- ## [0.124.15](https://github.com/googleapis/java-errorreporting/compare/v0.124.14...v0.124.15) (2022-10-10) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.21 ([#1001](https://github.com/googleapis/java-errorreporting/issues/1001)) ([b3722f8](https://github.com/googleapis/java-errorreporting/commit/b3722f8ea2dde68869b824e80da3583d312c83cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.2 (#1002) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.1` -> `26.1.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/compatibility-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/confidence-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).

vkedia added 7 commits December 1, 2017 16:25

Add tracing

f65f72b

Fixes

d576ca0

tracing

d7e9520

Merge branch 'master' into tracing

1d1738f

Add tracing sample

4d755ab

Revert Quickstart

2f86625

Revert Spanner sample

74050b6

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2018

bogdandrutu approved these changes Jan 23, 2018

View reviewed changes

lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2018

Address review comments

6635352

Merge branch 'master' into tracing

794561c

lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2018

lesv previously approved these changes Jan 23, 2018

View reviewed changes

Fix style violations

29568ba

vkedia dismissed lesv’s stale review via 29568ba January 23, 2018 20:30

kurtisvg approved these changes Jan 23, 2018

View reviewed changes

kurtisvg merged commit 41df694 into GoogleCloudPlatform:master Jan 23, 2018

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-dialogflow #7420

Merged

9 tasks

Conversation

vkedia commented Jan 23, 2018

Uh oh!

bogdandrutu Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

bogdandrutu Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

bogdandrutu Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

bogdandrutu commented Jan 23, 2018

Uh oh!

lesv commented Jan 23, 2018

Uh oh!

lesv commented Jan 23, 2018

Uh oh!

bogdandrutu commented Jan 23, 2018

Uh oh!

vkedia commented Jan 23, 2018

Uh oh!

vkedia commented Jan 23, 2018

Uh oh!

vkedia commented Jan 23, 2018

Uh oh!

lesv commented Jan 23, 2018

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

kurtisvg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkedia commented Jan 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kurtisvg left a comment •

edited

Loading