Open
Conversation
Contributor
felickz
commented
Sep 3, 2025
- TODO: implement filterByLocation / checkSource for JS
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial support for partial queries in JavaScript, providing debugging tools to explore data flow paths from sources or to sinks with configurable exploration limits.
- Introduces two new partial path queries: one from sources and one from sinks
- Adds a remote sources exploration query with helper predicates for filtering by location
- Extends the utility library to support SQL injection sinks alongside existing sink types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
javascript/src/debugging/PartialPathsFromSource.ql |
New partial path query exploring flows from all sources with forward exploration |
javascript/src/debugging/PartialPathsFromSink.ql |
New partial path query exploring flows to all sinks with reverse exploration |
javascript/src/audit/explore/RemoteSources.ql |
New query to identify remote sources with location filtering capabilities |
javascript/lib/ghsl/Utils.qll |
Extended utility library with SQL injection sink support and centralized helper predicates |
Comments suppressed due to low confidence (4)
javascript/lib/ghsl/Utils.qll:1
- Variable name should be 'threatmodel' not 'threadmodel' to correctly represent threat modeling concepts.
/**
javascript/lib/ghsl/Utils.qll:1
- Variable references should use 'threatmodel' not 'threadmodel' to match the intended threat modeling terminology.
/**
javascript/lib/ghsl/Utils.qll:1
- Variable references should use 'threatmodel' not 'threadmodel' to match the intended threat modeling terminology.
/**
javascript/lib/ghsl/Utils.qll:1
- Variable reference should use 'threatmodel' not 'threadmodel' to match the intended threat modeling terminology.
/**
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.