Feat: only certain commands wake up the device#134
Open
JerrySB03 wants to merge 1 commit intoFrameworkComputer:mainfrom
Open
Feat: only certain commands wake up the device#134JerrySB03 wants to merge 1 commit intoFrameworkComputer:mainfrom
JerrySB03 wants to merge 1 commit intoFrameworkComputer:mainfrom
Conversation
Author
|
@JohnAZoidberg could i get a review? |
| #[cfg(feature = "b1display")] | ||
| Self::SetText(_) => true, | ||
|
|
||
| _ => false, |
Member
There was a problem hiding this comment.
I think it would be good to explicitly list the ones that shouldn't. StageGreyCol makes sense, what else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of #107 .
Previously all commands woke up the device, though that wasn't always wanted. Now only certain commands, that change brightness/grid wake up the device.
edit: also fix of #131 , #124 , partial fix of #108