Skip to content

fix: update to latest Intellij products#10

Merged
Flyrell merged 3 commits intoFlyrell:mainfrom
tscharke:bugs/update-to-latest-intellij-products
Aug 26, 2024
Merged

fix: update to latest Intellij products#10
Flyrell merged 3 commits intoFlyrell:mainfrom
tscharke:bugs/update-to-latest-intellij-products

Conversation

@tscharke
Copy link
Collaborator

@tscharke tscharke commented Aug 18, 2024

  • Runs with latest Intellij products (2024.2+)
  • Add a list of compatible products
  • Increase version of plugin

@tscharke tscharke force-pushed the bugs/update-to-latest-intellij-products branch 2 times, most recently from 232a172 to ce850d5 Compare August 18, 2024 11:33
@tscharke tscharke changed the title Update to latest Intellij products fix: update to latest Intellij products Aug 18, 2024
@tscharke tscharke force-pushed the bugs/update-to-latest-intellij-products branch from ce850d5 to 613f121 Compare August 18, 2024 11:36
@tscharke
Copy link
Collaborator Author

@Flyrell: Feel free to take a look 😃 And if it suits you, feel free to update the plugin on the marketplace.

@Mateusz-H
Copy link
Contributor

After building the plugin from your branch and installing it into webstorm, im stuck on tools/html attrubute folder settings
image

And as we can see plugin seems to be build correctly with version (1.1.2)
image

@tscharke
Copy link
Collaborator Author

Thanks @Mateusz-H for your feedback 🫣 Can you tell me which version of webstorm you tested it with? I'll take a look at it...

@tscharke
Copy link
Collaborator Author

tscharke commented Aug 25, 2024

@Mateusz-H I just tried it again with my branch (https://github.com/tscharke/html-attribute-folder/tree/bugs/update-to-latest-intellij-products) and WebStorm 2024.2.

Both the function and the settings screen work perfectly.

Bildschirmfoto 2024-08-25 um 15 06 58 Bildschirmfoto 2024-08-25 um 15 07 18

I've created a new release for my branch, which is available for download here.

Perhaps you would like to try it out and install version 1.1.2 of this plugin manually?

@Mateusz-H
Copy link
Contributor

@tscharke I'm very sorry for the inconvenience, I was using an older version of webstorm, after the update everything is fine.
image

@tscharke
Copy link
Collaborator Author

@Mateusz-H You don't have to apologise. I'm glad that it works for you now 😎

And I'm very happy about your interest 😊

Have fun and certainly this version of the plug-in will soon be available on the marketplace 🤞🤞🤞

@Flyrell Flyrell merged commit bbf5c9b into Flyrell:main Aug 26, 2024
@Flyrell
Copy link
Owner

Flyrell commented Aug 26, 2024

Hey guys, thanks for the update.

Honest talk, would any of you be interested in maintaining this plugin further? As I'm quite busy, I feel the best think I can do is to find someone who'd maintain it in the future.

Unfortunately, IntelliJ updates quite often breake the compatibility, so it's quite difficult to update it for me.

@Mateusz-H
Copy link
Contributor

Hey guys, thanks for the update.

Honest talk, would any of you be interested in maintaining this plugin further? As I'm quite busy, I feel the best think I can do is to find someone who'd maintain it in the future.

Unfortunately, IntelliJ updates quite often breake the compatibility, so it's quite difficult to update it for me.

I've never done anything in kotlin, however, I'm still looking for something to help me use tailwindcss (class wrap), so maybe a bigger contribution to html-attirbute-folder development can be beneficial to me.

@tscharke
Copy link
Collaborator Author

@Flyrell I use the plugin regularly because it is a useful tool for me 😎

As you can already see, I already support you. And yes, I can imagine officially supporting this project 😊

In my fork I've already automated the construction of a release. Maybe we could still install the publication on the marketplace here?

And would it be really cool if @Mateusz-H was also there and we did it together? What do you think?

@Flyrell
Copy link
Owner

Flyrell commented Aug 27, 2024

It's already published, just pending approval on JetBrains' side.

Screenshot 2024-08-27 at 08 36 19

And, of course, the more the merrier 😄

My plan would be to give you guys access to the repo, and as soon as I'm going to be able (or if you want to) set up the pipelines for building, signing & publishing the plugin when the tag is created. Maybe having some unit tests wouldn't hurt as well.

@tscharke tscharke deleted the bugs/update-to-latest-intellij-products branch August 31, 2024 06:21
tscharke pushed a commit that referenced this pull request Dec 18, 2025
…roducts

fix: update to latest Intellij products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants