This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Fix filtering keys with punctuation#57
Closed
fredsted wants to merge 1 commit intoFlowCommunications:masterfrom
Closed
Fix filtering keys with punctuation#57fredsted wants to merge 1 commit intoFlowCommunications:masterfrom
fredsted wants to merge 1 commit intoFlowCommunications:masterfrom
Conversation
|
In your example, you mean by "Employee.FirstName" really that there is a key named "Employee.FirstName", not that you want to access the "FirstName" on the "Employee", right? I need to access a sub-property inside the filter query like: What I want is
With this patch applied the error "Malformed filter query" is gone, but it seems that the query is not parsed correctly. |
Author
Yep, see the tests here, which demonstrates the problem. |
|
Ok, I see. So is there a way in the current implementation to use sub-properties in the filter string? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix inspired by #50 that fixes filtering keys containing non-letter characters, e.g.
.data.tokens[?(@.Employee.FirstName)]or[?(@.neighbor-id == "192.168.1.1")]as also described in #50.It basically causes the regex to match everything except
whitespaceand=. Let me know if it's too greedy, but all tests are passing.