feat: Support for PHP 8.5 #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
php85
branch
3 times, most recently
from
4727e23 to
a70c8a1
Compare
khvn26
approved these changes
Jan 23, 2026
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
LGTM, and thanks for the contribution! 👍
emyller
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @khvn26 @matthewelwell
softcreatr/jsonpath
^0.10does not support PHP 8.5+ ; so when @emyller added the lib as a dependency, the support for php 8.5 was lost. I added those version to the Ci to avoid such regression.Closes #127