fix: thread safe analytics processor#147
Merged
matthewelwell merged 2 commits intoFlagsmith:mainfrom Mar 27, 2024
Merged
Conversation
Contributor
matthewelwell
left a comment
There was a problem hiding this comment.
@Dogacel thanks for this, in general it looks great. I wonder if there is any more testing that we can add, or perhaps the existing tests cover it?
Contributor
Author
Those race conditions are certainly hard to catch in tests. I am not sure how to test them, I usually don't write thread-safe code too. |
matthewelwell
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed analytics processor threw some exceptions.
Looking at code it is evident that those operations are not thread safe. They should be thread-safe considering flag access is also not thread safe.
Changes:
analyticsDatato beConcurrentHashMap.flush()is only called once without concurrency.LongAdderwhich will have exact count rather than an approximation.