Merged
Conversation
khvn26
force-pushed
the
feat/schemas
branch
9 times, most recently
from
4665920 to
8407485
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9116109 |
khvn26
force-pushed
the
feat/schemas
branch
7 times, most recently
from
0041b66 to
e67ff89
Compare
3 tasks
matthewelwell
requested review from
gagantrivedi
and removed request for
novakzaballa
gagantrivedi
requested changes
Jun 14, 2023
gagantrivedi
previously requested changes
Jun 16, 2023
khvn26
force-pushed
the
feat/schemas
branch
2 times, most recently
from
f58217a to
7c21b16
Compare
khvn26
force-pushed
the
feat/schemas
branch
2 times, most recently
from
77a9af1 to
3cfa494
Compare
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Love this ^ 👌
I've added a few comments but, on the whole, it's really great to see where we're seeing the benefit from this refactor. It's harder to see in the other 2 PRs but you can definitely see it here!
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
No additional comments here - I've resolved most of the conversations that were outstanding but I think there are still a few left waiting for a response.
Member
Author
|
Merge this after #171 is merged and released. |
matthewelwell
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith#2079