feat: add verticalScrollbarPosition prop to ScrollView#33
Merged
Beamanator merged 1 commit intoExpensify:mainfrom Nov 21, 2022
Merged
Conversation
This is a temporary addition to help circumvent a bug on android. Long term we want to fix the root cause of the problem. - RN issue: facebook#35350 - Expensify issue: Expensify/App#11321 (comment)
97 tasks
mountiny
approved these changes
Nov 21, 2022
mountiny
left a comment
There was a problem hiding this comment.
This looks good to me, we would need to do a release of our branch. @roryabraham is that something you could help with?
|
@Beamanator looks like this was merged without the danger test passing. Please add a note explaining why this was done and remove the |
|
Tests were passing. |
|
I'm going to publish this under |
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a temporary addition to help circumvent a bug on android. Long term we want to fix the root cause of the problem.
Changelog
[Android] [Added] - add
verticalScrollbarPositionprop (can beleftorright)Test Plan