Skip to content

feat: add verticalScrollbarPosition prop to ScrollView#33

Merged
Beamanator merged 1 commit intoExpensify:mainfrom
hannojg:feat/scrollview-add-scrollvar-position
Nov 21, 2022
Merged

feat: add verticalScrollbarPosition prop to ScrollView#33
Beamanator merged 1 commit intoExpensify:mainfrom
hannojg:feat/scrollview-add-scrollvar-position

Conversation

@hannojg
Copy link

@hannojg hannojg commented Nov 17, 2022

Summary

This is a temporary addition to help circumvent a bug on android. Long term we want to fix the root cause of the problem.

Changelog

[Android] [Added] - add verticalScrollbarPosition prop (can be left or right)

Test Plan

This is a temporary addition to help circumvent a bug on android.
Long term we want to fix the root cause of the problem.

- RN issue: facebook#35350
- Expensify issue: Expensify/App#11321 (comment)
Copy link

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we would need to do a release of our branch. @roryabraham is that something you could help with?

Copy link

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me!

@Beamanator Beamanator merged commit 99c26e2 into Expensify:main Nov 21, 2022
@melvin-bot melvin-bot bot added the Emergency label Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

@Beamanator looks like this was merged without the danger test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link

Tests were passing.

@AndrewGable
Copy link

I'm going to publish this under expensify/react-native@0.70.4-alpha.2 Which will continue to use react native 0.70.4, but just with this commit added on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants