Conversation
intjftw
added
Kind: Enhancement 🌟
Status: WIP 👷
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Currently this metric calculates the number of aggregated types for each type. Shouldn't inheritance or e.g. function parameter types be considered as well? (Question, should be discussed.)
| @@ -1,4 +1,5 @@ | |||
| #include <cppmetricsparser/cppmetricsparser.h> | |||
| #include "efferent.h" | |||
There was a problem hiding this comment.
Incorrect inclusion order. Please refer to the coding conventions.
| ${PLUGIN_DIR}/model/include) | ||
|
|
||
| add_library(cxxmetricsparser SHARED | ||
| src/efferent.cpp |
There was a problem hiding this comment.
efferent.h should also be added here, so CMake can recognize that in case the header file changes, recompilation of the target is required.
…g to the cpp metrics service.
intjftw
removed
the
Status: WIP 👷
|
I complemented the calculation with inherited types, member function parameter types and member function local variable types, aside from the already calculated member field types. |
2 participants
This PR solves #673. I'd like to include multiple related tasks, hence the WIP label.
Refactoring of the C++ metrics plugin: organize metrics calculating functions into separate source files.Should be separate PR.
Test cases for efferent coupling.