Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are 2 docker images:
codecompass:devimage holds the development environment for CodeCompass.codecompass:webcontains a compiled CodeCompass with its runtime dependencies and is configured to easily launch theCodeCompass_webserverbinary.Unfortunately none of them suffices to use the
CodeCompass_parserbinary in a dockerized production environment.codecompass:devimage is not self-contained, only the dependencies are installed inside the container, the source code and the binaries of CodeCompass are outside it to support development. Starting with this image CodeCompass has to be downloaded and built first, which is unnecessary extra time spent.codecompass:webimage is a set up to create so called executing containers. Upon the start of a container theCodeCompass_webserveris started as a non-rootcodecompassuser inside the container. It requires significant extra work to circumvent this and use this image as the root user without starting the webserver, so some parsing can be done. (Root privilege is required to install the dependencies of the project to be parsed.)This pull request proposes to a third,
codecompass:runtimeimage which contains the built CodeCompass binaries and their runtime dependencies (but not those required only for compilation time). Then thecodecompass:webimage can be based upon thiscodecompass:runtimeand really only contain the dependencies of the webserver. (Smaller size.)I have also done some completion on the documentation.