Adding C++ compiler diagnostic messages to the database #403
Conversation
clang::DiagnosticConsumer is handling the diagnostic messages (compilation errors, warnings, notes, etc.) during C/C++ compilation. These diagnostic messages are collected and stored in the database.
bruntib
added
Kind: Enhancement 🌟
Plugin: C++
whisperity
changed the title
whisperity
left a comment
whisperity
left a comment
There was a problem hiding this comment.
LGTM. We need a follow up to wire reading this table in on the Web UI.
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Looks and works good, I only had a minor change request to remove a TODO message, then LGTM.
Am I right, that these logged messages are not available yet from the web interface? There is a getBuildLog endpoint in project.thrift, but I did found any call to it.
| const clang::Diagnostic& info_) | ||
| { | ||
| // TODO: Is this needed? | ||
| clang::DiagnosticConsumer::HandleDiagnostic(diagLevel_, info_); |
There was a problem hiding this comment.
This only increments the numWarnings or numErrors counters. We do not use them now, so technically it is not needed, but later it could be useful, so in my opinion we shall keep it and remove the TODO.
@mcserep Yes, the similar feature was never wired in. The JS code that builds the log table UI elements is there, but that function is also nowhere called. That function would be called with the records populated by the API call. |
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Removed TODO. Ready to be merged after CI passes.
3 participants
clang::DiagnosticConsumeris handling the diagnostic messages (compilation errors, warnings, notes, etc.) during C/C++ compilation. These diagnostic messages are collected and stored in the database.