Wire in SSL certificate support #387
Conversation
whisperity
force-pushed
the
https-support
branch
from
8da12ba to
5e25200
Compare
csordasmarton
left a comment
csordasmarton
left a comment
There was a problem hiding this comment.
Some small comments otherwise LGTM!
| std::string filename = it->path().filename().native(); | ||
|
|
||
| if (!fs::is_directory(filename)) | ||
| // Ignore plain files in the workspace directory - projects are always |
There was a problem hiding this comment.
Maybe we can log some warning that the workspace directory contains some irrelevant files.
There was a problem hiding this comment.
I don't think this should be done... the "workspaceservice" should not have authority over what the webserver loads from there, etc. We'd have to duplicate ignoring "authentication.json", "certificate.pem" and potential other files here.
There was a problem hiding this comment.
Maybe we can log some warning that the workspace directory contains some irrelevant files.
The plugin registrar emits warnings in case the project directory does not contain the appropriate project_info.json - it was only workspace service which despite this, sent them name of the project out on the API.
whisperity
force-pushed
the
https-support
branch
from
5e25200 to
ed3c8b5
Compare
3 participants
If a
certificate.pemis found under the workspace, start the server with SSL enabled. Turns out the Mongoose we currently use actually does support this.