add test against fixed addresses#192
Merged
apoelstra merged 1 commit intoElementsProject:masterfrom Jan 15, 2024
Merged
Conversation
To prevent any regression in address computation. Should cover any standard script template combination with every network with or without a blinding key.
RCasatta
force-pushed
the
test_fixed_addresses
branch
from
5dc203e to
19a4d0d
Compare
Contributor
|
ACK 19a4d0d, tested locally, run tests for both master and 0.23 branch, checked diff in |
apoelstra
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent any regression in address computation.
Should cover any standard script template combination with every network with or without a blinding key.
Tested also on rust-elements v0.23.0 https://github.com/RCasatta/rust-elements/tree/test_fixed_addresses_023
related #188