Deprecate get_ prefix for Block and Transaction methods#128
Deprecate get_ prefix for Block and Transaction methods#128apoelstra merged 2 commits intoElementsProject:masterfrom
Conversation
To match the changes introduced in rust-bitcoin: rust-bitcoin/rust-bitcoin#861
|
I ran into this in electrs, where I ended up creating an Another incompatibility that I ran into is that rust-bitcoin (as of v0.28) iterates over witness elements as a (Initially I had to use |
| } | ||
|
|
||
| /// Get the size of the block | ||
| #[deprecated(since = "0.19.1", note = "Please use `Block::size` instead.")] |
There was a problem hiding this comment.
This assumes that the next release is going to be 0.19.1, which might not be the case.
|
I'm happy to do a quick point release if you want. There's nothing else in the queue. |
|
No urgency for me, I can keep using the compatibility trait until a new release is out. Thanks for merging! |
The EBCompact compatibility trait is no longer necessary, the `get` prefix was removed in ElementsProject/rust-elements#128
The EBCompact compatibility trait is no longer necessary, the `get` prefix was removed in ElementsProject/rust-elements#128
The EBCompact compatibility trait is no longer necessary, the `get` prefix was removed in ElementsProject/rust-elements#128
2 participants
To match the changes introduced in rust-bitcoin/rust-bitcoin#861.
This allows using unified code with the same methods for both
elements::{Transaction,Block}andbitcoin::{Transaction,Block}(behind different features), without triggering rust-bitcoin's deprecation warnings for theget_-prefixed methods.Note that there are other instances of
get_-prefixed methods in the rust-elements codebase. I only updated the ones needed for compatibility with the changes made in rust-bitcoin.