Chainparams: Unify CRegTestParams and CCustomParams#306
Merged
instagibbs merged 1 commit intoElementsProject:elements-0.14.1from Feb 20, 2018
Merged
Conversation
jtimon
force-pushed
the
e14-unify-regtest-custom
branch
from
4747444 to
361faad
Compare
3 tasks
jtimon
force-pushed
the
e14-unify-regtest-custom
branch
from
361faad to
0053760
Compare
jtimon
changed the title
jtimon
force-pushed
the
e14-unify-regtest-custom
branch
6 times, most recently
from
a659102 to
6dca473
Compare
bitcoin-backport-12128: One CBaseChainParams should be enough
jtimon
force-pushed
the
e14-unify-regtest-custom
branch
from
72705e4 to
b553501
Compare
Contributor
Author
|
replace-by-fee.py was failing because fRequireStandard was true by default instead of false, updated |
instagibbs
added a commit
that referenced
this pull request
Feb 20, 2018
b553501 Chainparams: Unify CRegTestParams and CCustomParams (Jorge Timón)
Contributor
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any class extending CChainParams directly should be fine.
Any class extending CRegTestParams should be fine, just extend CCustomParams instead (or just use the custom params if that's enough for your chain).
Dependencies:
- [ ] Chainparams: Every chain should have a name #307