-
Notifications
You must be signed in to change notification settings - Fork 103
Workaround for Python 3.9.7 operation #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Python 3.9.7 operation #458
Conversation
|
@ronnie-llamado I'm gonna take a deep dive and test this. May take a bit. This looks great. If this works, may ask to make a change to README and CI to remove the version restriction. |
|
@keithrfung I'm looking forward to what you potentially find in the deep dive. I'm still not entirely sure why it works without passing Another uncertainity: why did it only take explicitly defining As far as the other changes: No problem, I'll have the README/CI changes queued up. |
|
@ronnie-llamado It's a creative fix but I believe this works. Add the README and I will be waiting to approve. ✅ I believe I will make an issue to remove these in the future. The README and any other documentation can now say 3.9 instead of a specific version on the changes. |
keithrfung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought at one point, but It actually looks like |

Issue
Fixes #440
Description
__init__forManifest,InternationalizedText,ContactInformation, andLanguageinit=Falseis defined in dataclassTesting
make test