Reduce file size and dimensions of icon.svg#259
Open
andershol wants to merge 1 commit intoDualSPHysics:masterfrom
Open
Reduce file size and dimensions of icon.svg#259andershol wants to merge 1 commit intoDualSPHysics:masterfrom
andershol wants to merge 1 commit intoDualSPHysics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image
images/icon.svgis referenced bypackage.xmland has a rather large file size for an icon (1,3MB). Currently it takes up around 2/3 of the file size of the http://addons.freecad.org/addon_catalog_cache.zip, (base64-encoded and zipped it is ~1MB of 1,5MB) even though the zip-file contains data from over 150 addons (presumably based on https://github.com/FreeCAD/FreeCAD-addons ). The zip-file is used by the addon page on the freecad website where it has a similar effect (the compressed transfer size of the html is ~1,7MB).This was discussed in #14, where the user vocx created some variations of the icon, that were smaller in size and dimensions. These were accepted, but the icon file was never replaced in this repository. The smaller icons was put directly into the addonmanager as a resource, but has since been removed from there.
This commit replaces the icon-file with one of the variations created by vocx (which I have tweaked a bit, e.g. reduced file-size to ~4KB and reduced an outline slightly).