Skip to content

refactor: extract TDX quote report_data offset as a named constant #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvinwang merged 3 commits into from
Mar 17, 2026
Merged

refactor: extract TDX quote report_data offset as a named constant #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23e139f
refactor: extract TDX quote report_data offset as a named constant
kvinwang Mar 14, 2026
62067b5
chore: update Cargo.lock
kvinwang Mar 14, 2026
3eac438
style: fix cargo fmt for import
kvinwang Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dstack-attest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ serde_json.workspace = true
sha2.workspace = true
sha3.workspace = true
tdx-attest.workspace = true
tracing.workspace = true
insta.workspace = true
errify.workspace = true

Expand Down
15 changes: 13 additions & 2 deletions dstack-attest/src/attestation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

//! Attestation functions

/// Byte range of the REPORT_DATA field within a TDX quote.
/// In Intel TDX ECDSA quote format, the TD Report body starts at offset 568
/// and REPORT_DATA occupies bytes 568..632 (64 bytes).
pub const TDX_QUOTE_REPORT_DATA_RANGE: std::ops::Range<usize> = 568..632;

use std::{borrow::Cow, time::SystemTime};

use anyhow::{anyhow, bail, Context, Result};
Expand Down Expand Up @@ -274,8 +279,14 @@ impl VersionedAttestation {
let VersionedAttestation::V0 { attestation } = self;
attestation.report_data = report_data;
if let Some(tdx_quote) = attestation.tdx_quote_mut() {
if tdx_quote.quote.len() >= 632 {
tdx_quote.quote[568..632].copy_from_slice(&report_data);
if tdx_quote.quote.len() >= TDX_QUOTE_REPORT_DATA_RANGE.end {
tdx_quote.quote[TDX_QUOTE_REPORT_DATA_RANGE].copy_from_slice(&report_data);
} else {
tracing::warn!(
"TDX quote too short to patch report_data ({} < {})",
tdx_quote.quote.len(),
TDX_QUOTE_REPORT_DATA_RANGE.end
);
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions guest-agent/src/rpc_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ use k256::ecdsa::SigningKey;
use or_panic::ResultOrPanic;
use ra_rpc::{Attestation, CallContext, RpcCall};
use ra_tls::{
attestation::{QuoteContentType, VersionedAttestation, DEFAULT_HASH_ALGORITHM},
attestation::{
QuoteContentType, VersionedAttestation, DEFAULT_HASH_ALGORITHM, TDX_QUOTE_REPORT_DATA_RANGE,
},
cert::CertConfigV2,
kdf::{derive_key, derive_p256_key_pair_from_bytes},
};
Expand Down Expand Up @@ -486,7 +488,7 @@ fn simulate_quote(
return Err(anyhow::anyhow!("Quote not found"));
};

quote.quote[568..632].copy_from_slice(&report_data);
quote.quote[TDX_QUOTE_REPORT_DATA_RANGE].copy_from_slice(&report_data);
Ok(GetQuoteResponse {
quote: quote.quote.to_vec(),
event_log: serde_json::to_string(&quote.event_log)
Expand Down
Loading