Skip to content

Conversation

@anna-shakhova
Copy link
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Jan 14, 2026
@anna-shakhova anna-shakhova changed the title [WIP] DataGrid: remove unnecessary code from filter_row DataGrid: remove unnecessary code from filter_row Jan 16, 2026
@anna-shakhova anna-shakhova marked this pull request as ready for review January 16, 2026 12:07
@anna-shakhova anna-shakhova requested a review from a team as a code owner January 16, 2026 12:07
Copilot AI review requested due to automatic review settings January 16, 2026 12:07
@anna-shakhova anna-shakhova changed the title DataGrid: remove unnecessary code from filter_row DataGrid: fix Tab press handler in filter range (T1312521) Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the DataGrid filter row code by removing unnecessary/redundant code and improving type safety and test organization.

Changes:

  • Refactored filter range overlay container positioning to be relative to grid headers instead of viewport
  • Improved Tab key navigation logic to handle the last column edge case
  • Enhanced type safety by adding MenuInternal type import and removing TypeScript error suppressions
  • Reorganized TestCafe tests by separating visual and functional tests into dedicated files

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/filterRow.tests.js Added helper function getFilterRowOverlay() to simplify test assertions and updated all overlay selector references
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts Changed overlay container from viewport to grid element, improved Tab navigation to handle last column, added MenuInternal type, removed unnecessary blur trigger
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/visual.ts New file containing visual/screenshot tests previously in functional.ts
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts Removed visual tests (moved to visual.ts), cleaned up imports, reorganized test order
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/T1163100_changeFIlterIcon.visual_matrix.ts New test file for T1163100 filter icon change visual tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant