refactor: minor refactoring

[DaxServer]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

New Features

• Introduced comprehensive coding guidelines for frontend and backend development, including standards for styling, auto-imports, path aliasing, and testing.
• Added detailed frontend schema validation types and error handling.

Bug Fixes

• Updated documentation and scripts to remove references to Vitest and clarify test runner usage.

Refactor

• Removed suggestions from drag-and-drop validation feedback.
• Updated type imports and streamlined type exports.
• Consolidated and improved test assertions for drag-and-drop functionality.

Chores

• Added and updated Bun type dependencies across the project.
• Adjusted TypeScript configuration for type declarations and output emission.
• Enhanced Vite server configuration to ignore test files during development.

Documentation

• Added and revised documentation for coding conventions, testing practices, and technical standards.

Walkthrough

This update revises coding guidelines, removes detailed frontend standards from technical documentation, and introduces a new coding conventions document. It removes the "suggestions" property from drag-and-drop validation types and logic, updates related tests, adds the "bun-types" dependency, and adjusts TypeScript configuration and test runner documentation. Several import paths and assertion styles in tests are also updated.

Changes

File(s)	Change Summary
.kiro/steering/code-conventions.md	Added comprehensive coding conventions and guidelines for frontend and backend development, including code style, imports, path aliasing, and testing practices.
.kiro/steering/tech.md	Removed detailed sections on coding standards, frontend auto-import configuration, and path aliasing.
frontend/src/types/drag-drop.ts frontend/src/composables/useDragDropContext.ts	Removed suggestions property from drag-and-drop validation and feedback types and logic; deleted related helper function and all references.
frontend/src/types/index.ts	Removed re-exports of types from ./schema-mapping and ./drag-drop.
frontend/src/types/wikibase-schema.ts	Added detailed validation error types, codes, context, and messages; replaced and renamed several interfaces.
frontend/src/composables/tests/useDragDropContext.test.ts frontend/src/types/tests/drag-drop-context.test.ts frontend/src/types/tests/drag-drop.test.ts frontend/src/types/tests/drop-target-validation.test.ts	Updated import paths, removed assertions for suggestions, consolidated and refactored tests, and switched to deep equality assertions for objects.
.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc guidelines/reference/TESTING.md	Updated documentation to remove references to Vitest as a test runner and tool.
backend/package.json frontend/package.json package.json	Added "bun-types" dependency to backend, frontend, and root workspaces.
frontend/package.json	Removed --build flag from vue-tsc in the typecheck script.
tsconfig.base.json	Changed TypeScript types from @types/bun to bun-types.
frontend/tsconfig.vite.json	Removed "noEmit": true" from TypeScript compiler options.
frontend/vite.config.ts	Configured Vite dev server to ignore **/*.test.ts files in its watch pattern.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant DragDropContext
    participant Validation

    User->>UI: Initiates drag-and-drop
    UI->>DragDropContext: Start drag
    DragDropContext->>Validation: Validate drop (no suggestions)
    Validation-->>DragDropContext: Returns DropValidation (no suggestions)
    DragDropContext-->>UI: Provides feedback (no suggestions)
    User->>UI: Drops item
    UI->>DragDropContext: Perform drop
    DragDropContext->>Validation: Validate drop (no suggestions)
    Validation-->>DragDropContext: Returns DropValidation (no suggestions)
    DragDropContext-->>UI: Updates state

Loading

Possibly related PRs

• DaxServer/dataforge#70: Introduces initial drag-and-drop context types and utilities, which are directly modified and extended in this PR (removal of suggestions and related logic).

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 044c5b5 and d5e025e.

⛔ Files ignored due to path filters (1)

• bun.lock is excluded by !**/*.lock

📒 Files selected for processing (18)

• .cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc (1 hunks)
• .kiro/steering/code-conventions.md (1 hunks)
• .kiro/steering/tech.md (0 hunks)
• backend/package.json (1 hunks)
• frontend/package.json (2 hunks)
• frontend/src/composables/__tests__/useDragDropContext.test.ts (8 hunks)
• frontend/src/composables/useDragDropContext.ts (1 hunks)
• frontend/src/types/__tests__/drag-drop-context.test.ts (4 hunks)
• frontend/src/types/__tests__/drag-drop.test.ts (15 hunks)
• frontend/src/types/__tests__/drop-target-validation.test.ts (2 hunks)
• frontend/src/types/drag-drop.ts (1 hunks)
• frontend/src/types/index.ts (0 hunks)
• frontend/src/types/wikibase-schema.ts (2 hunks)
• frontend/tsconfig.vite.json (0 hunks)
• frontend/vite.config.ts (1 hunks)
• guidelines/reference/TESTING.md (2 hunks)
• package.json (1 hunks)
• tsconfig.base.json (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.