Skip to content

refactor: extract statement preview component, drop dumb tests #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaxServer merged 1 commit into from
Aug 2, 2025
Merged

refactor: extract statement preview component, drop dumb tests #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ declare module 'vue' {
Sidebar: typeof import('./src/components/Sidebar.vue')['default']
StatementConfigEditor: typeof import('./src/components/StatementConfigEditor.vue')['default']
StatementEditor: typeof import('./src/components/StatementEditor.vue')['default']
StatementPreview: typeof import('./src/components/StatementPreview.vue')['default']
StatementsEditor: typeof import('./src/components/StatementsEditor.vue')['default']
Tab: typeof import('primevue/tab')['default']
TabList: typeof import('primevue/tablist')['default']
Expand Down
131 changes: 5 additions & 126 deletions frontend/src/components/StatementEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,132 +522,11 @@ watch(
</div>

<!-- Preview -->
<div
<StatementPreview
v-if="isValidStatement"
class="border-t border-surface-200 pt-4"
>
<h5 class="text-sm font-medium text-surface-700 mb-2">Preview</h5>
<div class="bg-white border border-surface-200 rounded p-3 text-sm">
<div class="flex items-center gap-2 mb-1">
<Tag
:value="localStatement.property?.id"
size="small"
severity="info"
/>
<span class="font-medium">
{{ localStatement.property?.label || localStatement.property?.id }}
</span>
</div>
<div class="flex items-center gap-2 text-surface-600 ml-4">
<i class="pi pi-arrow-right text-xs" />
<Tag
:value="
localStatement.value.type === 'column'
? localStatement.value.source.columnName
: localStatement.value.source
"
size="small"
severity="secondary"
/>
<span class="text-xs">{{ localStatement.value.dataType }}</span>
<Tag
:value="localStatement.rank"
:severity="rankOptions.find((r) => r.value === localStatement.rank)?.severity"
size="small"
/>
</div>

<!-- Qualifiers Preview -->
<div
v-if="localQualifiers.length > 0"
class="ml-8 mt-3 border-l-2 border-primary-200 pl-3 bg-gradient-to-r from-primary-25 to-transparent rounded-r"
data-testid="qualifiers-preview"
>
<div class="text-xs text-primary-700 font-medium mb-2 flex items-center gap-1">
<i class="pi pi-tags text-xs" />
<span>Qualifiers ({{ localQualifiers.length }}):</span>
</div>
<div class="space-y-2">
<div
v-for="(qualifier, index) in localQualifiers"
:key="`preview-qualifier-${index}`"
class="flex items-center gap-2 text-xs text-surface-600 p-2 bg-white/50 rounded border border-primary-100"
data-testid="qualifier-preview-item"
>
<div class="flex items-center gap-1 text-primary-600">
<i class="pi pi-angle-right text-xs" />
<span class="font-medium">Q{{ index + 1 }}</span>
</div>
<span class="font-medium">
{{ qualifier.property.label || qualifier.property.id }}:
</span>
<Tag
:value="
qualifier.value.type === 'column'
? qualifier.value.source.columnName
: qualifier.value.source
"
size="small"
severity="secondary"
/>
<span class="text-surface-400">{{ qualifier.value.dataType }}</span>
</div>
</div>
</div>

<!-- References Preview -->
<div
v-if="localReferences.length > 0"
class="ml-8 mt-3 border-l-2 border-orange-200 pl-3 bg-gradient-to-r from-orange-25 to-transparent rounded-r"
data-testid="references-preview"
>
<div class="text-xs text-orange-700 font-medium mb-2 flex items-center gap-1">
<i class="pi pi-bookmark text-xs" />
<span>References ({{ localReferences.length }}):</span>
</div>
<div class="space-y-3">
<div
v-for="(reference, refIndex) in localReferences"
:key="`preview-reference-${reference.id}`"
class="p-2 bg-white/50 rounded border border-orange-100"
data-testid="reference-preview-item"
>
<div class="flex items-center gap-1 text-orange-600 mb-2">
<i class="pi pi-bookmark text-xs" />
<span class="font-medium text-xs">R{{ refIndex + 1 }}</span>
<span class="text-xs text-surface-500">
({{ reference.snaks.length }}
{{ reference.snaks.length === 1 ? 'property' : 'properties' }})
</span>
</div>
<div class="space-y-1 ml-3">
<div
v-for="(snak, snakIndex) in reference.snaks"
:key="`preview-snak-${refIndex}-${snakIndex}`"
class="flex items-center gap-2 text-xs text-surface-600"
data-testid="reference-snak-preview-item"
>
<div class="flex items-center gap-1 text-orange-600">
<i class="pi pi-angle-right text-xs" />
<span class="font-medium">R{{ refIndex + 1 }}.{{ snakIndex + 1 }}</span>
</div>
<span class="font-medium">{{ snak.property.label || snak.property.id }}:</span>
<Tag
:value="
snak.value.type === 'column'
? snak.value.source.columnName
: snak.value.source
"
size="small"
severity="secondary"
/>
<span class="text-surface-400">{{ snak.value.dataType }}</span>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
:statement="localStatement"
:qualifiers="localQualifiers"
:references="localReferences"
/>
</div>
</template>
149 changes: 149 additions & 0 deletions frontend/src/components/StatementPreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
<script setup lang="ts">
// Props
interface StatementPreviewProps {
statement: {
property: PropertyReference | null
value: ValueMapping
rank: StatementRank
}
qualifiers?: PropertyValueMap[]
references?: ReferenceSchemaMapping[]
}

withDefaults(defineProps<StatementPreviewProps>(), {
qualifiers: () => [],
references: () => [],
})

// Rank options for severity mapping
const rankOptions = [
{ value: 'preferred', severity: 'success' },
{ value: 'normal', severity: 'info' },
{ value: 'deprecated', severity: 'warn' },
]
</script>

<template>
<div class="border-t border-surface-200 pt-4">
<h5 class="text-sm font-medium text-surface-700 mb-2">Preview</h5>
<div class="bg-white border border-surface-200 rounded p-3 text-sm">
<div class="flex items-center gap-2 mb-1">
<Tag
:value="statement.property?.id"
size="small"
severity="info"
/>
<span class="font-medium">
{{ statement.property?.label || statement.property?.id }}
</span>
</div>
<div class="flex items-center gap-2 text-surface-600 ml-4">
<i class="pi pi-arrow-right text-xs" />
<Tag
:value="
statement.value.type === 'column'
? statement.value.source.columnName
: statement.value.source
"
size="small"
severity="secondary"
/>
<span class="text-xs">{{ statement.value.dataType }}</span>
<Tag
:value="statement.rank"
:severity="rankOptions.find((r) => r.value === statement.rank)?.severity"
size="small"
/>
</div>

<!-- Qualifiers Preview -->
<div
v-if="qualifiers.length > 0"
class="ml-8 mt-3 border-l-2 border-primary-200 pl-3 bg-gradient-to-r from-primary-25 to-transparent rounded-r"
data-testid="qualifiers-preview"
>
<div class="text-xs text-primary-700 font-medium mb-2 flex items-center gap-1">
<i class="pi pi-tags text-xs" />
<span>Qualifiers ({{ qualifiers.length }}):</span>
</div>
<div class="space-y-2">
<div
v-for="(qualifier, index) in qualifiers"
:key="`preview-qualifier-${index}`"
class="flex items-center gap-2 text-xs text-surface-600 p-2 bg-white/50 rounded border border-primary-100"
data-testid="qualifier-preview-item"
>
<div class="flex items-center gap-1 text-primary-600">
<i class="pi pi-angle-right text-xs" />
<span class="font-medium">Q{{ index + 1 }}</span>
</div>
<span class="font-medium">
{{ qualifier.property.label || qualifier.property.id }}:
</span>
<Tag
:value="
qualifier.value.type === 'column'
? qualifier.value.source.columnName
: qualifier.value.source
"
size="small"
severity="secondary"
/>
<span class="text-surface-400">{{ qualifier.value.dataType }}</span>
</div>
</div>
</div>

<!-- References Preview -->
<div
v-if="references.length > 0"
class="ml-8 mt-3 border-l-2 border-orange-200 pl-3 bg-gradient-to-r from-orange-25 to-transparent rounded-r"
data-testid="references-preview"
>
<div class="text-xs text-orange-700 font-medium mb-2 flex items-center gap-1">
<i class="pi pi-bookmark text-xs" />
<span>References ({{ references.length }}):</span>
</div>
<div class="space-y-3">
<div
v-for="(reference, refIndex) in references"
:key="`preview-reference-${reference.id}`"
class="p-2 bg-white/50 rounded border border-orange-100"
data-testid="reference-preview-item"
>
<div class="flex items-center gap-1 text-orange-600 mb-2">
<i class="pi pi-bookmark text-xs" />
<span class="font-medium text-xs">R{{ refIndex + 1 }}</span>
<span class="text-xs text-surface-500">
({{ reference.snaks.length }}
{{ reference.snaks.length === 1 ? 'property' : 'properties' }})
</span>
</div>
<div class="space-y-1 ml-3">
<div
v-for="(snak, snakIndex) in reference.snaks"
:key="`preview-snak-${refIndex}-${snakIndex}`"
class="flex items-center gap-2 text-xs text-surface-600"
data-testid="reference-snak-preview-item"
>
<div class="flex items-center gap-1 text-orange-600">
<i class="pi pi-angle-right text-xs" />
<span class="font-medium">R{{ refIndex + 1 }}.{{ snakIndex + 1 }}</span>
</div>
<span class="font-medium">{{ snak.property.label || snak.property.id }}:</span>
<Tag
:value="
snak.value.type === 'column' ? snak.value.source.columnName : snak.value.source
"
size="small"
severity="secondary"
/>
<span class="text-surface-400">{{ snak.value.dataType }}</span>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</template>
11 changes: 0 additions & 11 deletions frontend/src/components/__tests__/ItemEditor.compile.test.ts
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions frontend/src/components/__tests__/ItemEditor.integration.test.ts
View file
Open in desktop

This file was deleted.

Loading