Change keep to Boolean object so that null is a valid value#183
Change keep to Boolean object so that null is a valid value#183sezen-datadog wants to merge 1 commit intomasterfrom
Conversation
sezen-datadog
force-pushed
the
fix-keep
branch
from
cf1f4ff to
d879c8c
Compare
jandro996
left a comment
jandro996
left a comment
There was a problem hiding this comment.
LGTM, just a few comments!
Do we have any tests that validate the default value and check this behavior explicitly?
Also, it might be helpful to add a short description in the PR explaining the motivation behind the change, it could be useful for reviewers now and also in the future if we need to look back at this.
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-devflow
bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
2 participants
This allows the waf to decide whether or not it decides to keep