Skip to content

Adds span and basic tracer.#2

Merged
jcchavezs merged 1 commit intomasterfrom
adds_span
Feb 7, 2018
Merged

Adds span and basic tracer.#2
jcchavezs merged 1 commit intomasterfrom
adds_span

Conversation

@jcchavezs
Copy link
Contributor

@jcchavezs jcchavezs commented Feb 6, 2018

This PR adds the Span class and a basic tracer.

Ping @palazzem

@palazzem palazzem self-requested a review February 7, 2018 10:21
@palazzem palazzem added the 🍏 core Changes to the core tracing functionality label Feb 7, 2018
@palazzem palazzem added this to the 0.1.0 milestone Feb 7, 2018
palazzem
palazzem suggested changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to drop the Service API (that sends service metadata) since it's not needed. Other than that it's a good start. Thank you very much!

src/DDTrace/Span.php
*/
public function setMeta($key, $value)
{
if ($this->isFinished()) {
Copy link
Contributor

@palazzem palazzem Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/DDTrace/Tracer.php Outdated
$this->traces[$span->getTraceId()][] = $span;
}

private function flushServices()
Copy link
Contributor

@palazzem palazzem Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the service API. Actually we rely in the span.type to define what kind of service this span belong (so it's a database span or a web span?). This has been introduced recently with the latest version of the Agent (5.21.1+). Some Tracers still have it (Python, Ruby and Go) just for backward compatibility. New Tracers don't need to use this endpoint.

Copy link
Contributor Author

@jcchavezs jcchavezs Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feedback. I will remove it and merge this PR.

@jcchavezs jcchavezs merged commit 045a918 into master Feb 7, 2018
@jcchavezs jcchavezs deleted the adds_span branch February 7, 2018 18:55
@morrisonlevi morrisonlevi mentioned this pull request Nov 3, 2020
Closed
bwoebi pushed a commit that referenced this pull request Sep 15, 2023
@Anilm3
Merge pull request #2 from DataDog/anilm3/thread-pool
498444b 
Thread Pool - Reuse idle threads
@derickr derickr mentioned this pull request Dec 7, 2023
Closed
@elzekool elzekool mentioned this pull request Apr 17, 2024
Open
iamluc added a commit that referenced this pull request May 27, 2024
@iamluc
Fix memory leak:
2e84fcd 
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
    #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
    #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
    #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
    #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
    #5 0xffff8b16a70b  (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)

SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
iamluc added a commit that referenced this pull request May 27, 2024
@iamluc
Fix memory leak:
c87a954 
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
    #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
    #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
    #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
    #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
    #5 0xffff8b16a70b  (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)

SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
bwoebi added a commit that referenced this pull request May 28, 2024
@iamluc @bwoebi
Collect trace_api.{requests,responses,errors} metrics in the backgrou…
6307408 
…nd trace sender (#2672)

* Make use of the sidecar thread safe

* Collect trace_api.{requests,responses,errors} in the background trace sender

* Fix test

* Fix memory leak:

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
    #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
    #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
    #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
    #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
    #5 0xffff8b16a70b  (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)

SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).

* Update libdatadog

* Fix tests

* Try running system tests with sidecar sender

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Don't explicitly flush the bgs telemetry data

* Improve test stability

* Try to run system-tests from a fork

* Fix telemetry tests

* Shut up instrumentation telemetry in web tests

* Fix flakiness

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Better flaky test check

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

---------

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
@josephwynn-sc josephwynn-sc mentioned this pull request Aug 11, 2024
Closed
@morrisonlevi morrisonlevi mentioned this pull request Jan 11, 2026
Draft
2 tasks
leoromanovsky added a commit that referenced this pull request Feb 11, 2026
@leoromanovsky
chore: Bump libdatadog to ed316b638 (FFE remote config support)
be2b697 
Update libdatadog submodule to include:
- feat: Add FFE_FLAGS remote config product and capability (#1532)

This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities::
FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the
remote config layer. Required for the PHP FFE integration (PR #2).

Cargo.lock regenerated with pins for CI compatibility:
home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
leoromanovsky added a commit that referenced this pull request Feb 12, 2026
@leoromanovsky
chore: Bump libdatadog to ed316b638 (FFE remote config support)
f3d286f 
Update libdatadog submodule to include:
- feat: Add FFE_FLAGS remote config product and capability (#1532)

This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities::
FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the
remote config layer. Required for the PHP FFE integration (PR #2).

Cargo.lock regenerated with pins for CI compatibility:
home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
leoromanovsky added a commit that referenced this pull request Feb 12, 2026
@leoromanovsky
chore: Bump libdatadog to ed316b638 (FFE remote config support)
42707d3 
Update libdatadog submodule to include:
- feat: Add FFE_FLAGS remote config product and capability (#1532)

This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities::
FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the
remote config layer. Required for the PHP FFE integration (PR #2).

Cargo.lock regenerated with pins for CI compatibility:
home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@palazzem palazzem palazzem requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🍏 core Changes to the core tracing functionality

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jcchavezs @palazzem