Propagate response body in case of non 200 status code.#10593
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065767
Total [baseline] (8.741 s) : 0, 8741075
Agent [candidate] (1.064 s) : 0, 1064209
Total [candidate] (8.762 s) : 0, 8761510
section iast
Agent [baseline] (1.24 s) : 0, 1239589
Total [baseline] (9.371 s) : 0, 9371309
Agent [candidate] (1.231 s) : 0, 1230849
Total [candidate] (9.34 s) : 0, 9340277
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (629.053 ms) : 0, 629053
BytebuddyAgent [candidate] (629.311 ms) : 0, 629311
AgentMeter [baseline] (28.961 ms) : 0, 28961
AgentMeter [candidate] (29.03 ms) : 0, 29030
GlobalTracer [baseline] (257.316 ms) : 0, 257316
GlobalTracer [candidate] (258.271 ms) : 0, 258271
AppSec [baseline] (32.921 ms) : 0, 32921
AppSec [candidate] (32.615 ms) : 0, 32615
Debugger [baseline] (61.394 ms) : 0, 61394
Debugger [candidate] (60.311 ms) : 0, 60311
Remote Config [baseline] (625.257 µs) : 0, 625
Remote Config [candidate] (619.567 µs) : 0, 620
Telemetry [baseline] (11.392 ms) : 0, 11392
Telemetry [candidate] (12.159 ms) : 0, 12159
Flare Poller [baseline] (7.612 ms) : 0, 7612
Flare Poller [candidate] (5.377 ms) : 0, 5377
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (801.666 ms) : 0, 801666
BytebuddyAgent [candidate] (795.981 ms) : 0, 795981
AgentMeter [baseline] (11.477 ms) : 0, 11477
AgentMeter [candidate] (11.246 ms) : 0, 11246
GlobalTracer [baseline] (249.549 ms) : 0, 249549
GlobalTracer [candidate] (248.209 ms) : 0, 248209
IAST [baseline] (27.174 ms) : 0, 27174
IAST [candidate] (26.842 ms) : 0, 26842
AppSec [baseline] (33.268 ms) : 0, 33268
AppSec [candidate] (33.924 ms) : 0, 33924
Debugger [baseline] (67.06 ms) : 0, 67060
Debugger [candidate] (65.554 ms) : 0, 65554
Remote Config [baseline] (539.493 µs) : 0, 539
Remote Config [candidate] (540.321 µs) : 0, 540
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.62 ms) : 0, 8620
Flare Poller [baseline] (3.558 ms) : 0, 3558
Flare Poller [candidate] (3.482 ms) : 0, 3482
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073310
Total [baseline] (10.905 s) : 0, 10904907
Agent [candidate] (1.062 s) : 0, 1061752
Total [candidate] (10.844 s) : 0, 10843699
section appsec
Agent [baseline] (1.24 s) : 0, 1240098
Total [baseline] (11.025 s) : 0, 11024590
Agent [candidate] (1.244 s) : 0, 1243631
Total [candidate] (10.968 s) : 0, 10968037
section iast
Agent [baseline] (1.234 s) : 0, 1233996
Total [baseline] (11.225 s) : 0, 11224846
Agent [candidate] (1.242 s) : 0, 1242073
Total [candidate] (11.239 s) : 0, 11239077
section profiling
Agent [baseline] (1.198 s) : 0, 1198012
Total [baseline] (11.039 s) : 0, 11039421
Agent [candidate] (1.188 s) : 0, 1187787
Total [candidate] (10.911 s) : 0, 10910801
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (633.352 ms) : 0, 633352
BytebuddyAgent [candidate] (627.208 ms) : 0, 627208
AgentMeter [baseline] (29.102 ms) : 0, 29102
AgentMeter [candidate] (28.947 ms) : 0, 28947
GlobalTracer [baseline] (258.734 ms) : 0, 258734
GlobalTracer [candidate] (256.918 ms) : 0, 256918
AppSec [baseline] (33.096 ms) : 0, 33096
AppSec [candidate] (32.717 ms) : 0, 32717
Debugger [baseline] (65.694 ms) : 0, 65694
Debugger [candidate] (60.564 ms) : 0, 60564
Remote Config [baseline] (613.837 µs) : 0, 614
Remote Config [candidate] (619.626 µs) : 0, 620
Telemetry [baseline] (10.704 ms) : 0, 10704
Telemetry [candidate] (12.226 ms) : 0, 12226
Flare Poller [baseline] (5.423 ms) : 0, 5423
Flare Poller [candidate] (6.078 ms) : 0, 6078
section appsec
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (658.452 ms) : 0, 658452
BytebuddyAgent [candidate] (660.398 ms) : 0, 660398
AgentMeter [baseline] (12.02 ms) : 0, 12020
AgentMeter [candidate] (12.0 ms) : 0, 12000
GlobalTracer [baseline] (258.338 ms) : 0, 258338
GlobalTracer [candidate] (259.465 ms) : 0, 259465
IAST [baseline] (25.17 ms) : 0, 25170
IAST [candidate] (25.329 ms) : 0, 25329
AppSec [baseline] (168.238 ms) : 0, 168238
AppSec [candidate] (168.056 ms) : 0, 168056
Debugger [baseline] (67.239 ms) : 0, 67239
Debugger [candidate] (67.665 ms) : 0, 67665
Remote Config [baseline] (659.759 µs) : 0, 660
Remote Config [candidate] (679.64 µs) : 0, 680
Telemetry [baseline] (9.703 ms) : 0, 9703
Telemetry [candidate] (9.788 ms) : 0, 9788
Flare Poller [baseline] (3.73 ms) : 0, 3730
Flare Poller [candidate] (3.815 ms) : 0, 3815
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (796.707 ms) : 0, 796707
BytebuddyAgent [candidate] (804.226 ms) : 0, 804226
AgentMeter [baseline] (11.257 ms) : 0, 11257
AgentMeter [candidate] (11.547 ms) : 0, 11547
GlobalTracer [baseline] (249.008 ms) : 0, 249008
GlobalTracer [candidate] (250.304 ms) : 0, 250304
IAST [baseline] (26.996 ms) : 0, 26996
IAST [candidate] (26.717 ms) : 0, 26717
AppSec [baseline] (33.21 ms) : 0, 33210
AppSec [candidate] (32.01 ms) : 0, 32010
Debugger [baseline] (67.736 ms) : 0, 67736
Debugger [candidate] (68.174 ms) : 0, 68174
Remote Config [baseline] (540.406 µs) : 0, 540
Remote Config [candidate] (543.733 µs) : 0, 544
Telemetry [baseline] (8.591 ms) : 0, 8591
Telemetry [candidate] (8.53 ms) : 0, 8530
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.389 ms) : 0, 3389
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (687.448 ms) : 0, 687448
BytebuddyAgent [candidate] (681.3 ms) : 0, 681300
AgentMeter [baseline] (8.717 ms) : 0, 8717
AgentMeter [candidate] (8.571 ms) : 0, 8571
GlobalTracer [baseline] (217.374 ms) : 0, 217374
GlobalTracer [candidate] (215.422 ms) : 0, 215422
AppSec [baseline] (32.846 ms) : 0, 32846
AppSec [candidate] (32.396 ms) : 0, 32396
Debugger [baseline] (67.419 ms) : 0, 67419
Debugger [candidate] (66.845 ms) : 0, 66845
Remote Config [baseline] (621.077 µs) : 0, 621
Remote Config [candidate] (623.646 µs) : 0, 624
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (8.857 ms) : 0, 8857
Flare Poller [baseline] (3.763 ms) : 0, 3763
Flare Poller [candidate] (3.748 ms) : 0, 3748
ProfilingAgent [baseline] (99.33 ms) : 0, 99330
ProfilingAgent [candidate] (99.001 ms) : 0, 99001
Profiling [baseline] (99.904 ms) : 0, 99904
Profiling [candidate] (99.567 ms) : 0, 99567
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1165, 1188
. : milestone, 1177,
iast (3.197 ms) : 3152, 3241
. : milestone, 3197,
iast_FULL (5.965 ms) : 5905, 6026
. : milestone, 5965,
iast_GLOBAL (3.548 ms) : 3491, 3605
. : milestone, 3548,
profiling (1.968 ms) : 1952, 1985
. : milestone, 1968,
tracing (1.794 ms) : 1778, 1809
. : milestone, 1794,
section candidate
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.068 ms) : 3032, 3105
. : milestone, 3068,
iast_FULL (5.9 ms) : 5841, 5959
. : milestone, 5900,
iast_GLOBAL (3.684 ms) : 3623, 3745
. : milestone, 3684,
profiling (2.256 ms) : 2232, 2279
. : milestone, 2256,
tracing (1.811 ms) : 1796, 1825
. : milestone, 1811,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section baseline
no_agent (19.316 ms) : 19119, 19513
. : milestone, 19316,
appsec (18.751 ms) : 18564, 18938
. : milestone, 18751,
code_origins (18.867 ms) : 18676, 19058
. : milestone, 18867,
iast (17.527 ms) : 17354, 17699
. : milestone, 17527,
profiling (18.556 ms) : 18368, 18745
. : milestone, 18556,
tracing (17.411 ms) : 17240, 17582
. : milestone, 17411,
section candidate
no_agent (19.067 ms) : 18873, 19261
. : milestone, 19067,
appsec (18.688 ms) : 18498, 18877
. : milestone, 18688,
code_origins (17.665 ms) : 17487, 17843
. : milestone, 17665,
iast (17.569 ms) : 17391, 17746
. : milestone, 17569,
profiling (19.71 ms) : 19511, 19909
. : milestone, 19710,
tracing (18.603 ms) : 18412, 18794
. : milestone, 18603,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.569 ms) : 2511, 2626
. : milestone, 2569,
iast (2.238 ms) : 2170, 2306
. : milestone, 2238,
iast_GLOBAL (2.284 ms) : 2215, 2353
. : milestone, 2284,
profiling (2.11 ms) : 2054, 2166
. : milestone, 2110,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.776 ms) : 3555, 3996
. : milestone, 3776,
iast (2.238 ms) : 2169, 2307
. : milestone, 2238,
iast_GLOBAL (2.284 ms) : 2215, 2352
. : milestone, 2284,
profiling (2.07 ms) : 2016, 2125
. : milestone, 2070,
tracing (2.048 ms) : 1995, 2101
. : milestone, 2048,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~fd7d4e6e17, baseline=1.60.0-SNAPSHOT~4d6eb0ee6d
dateFormat X
axisFormat %s
section baseline
no_agent (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
appsec (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
iast (17.776 s) : 17776000, 17776000
. : milestone, 17776000,
iast_GLOBAL (17.913 s) : 17913000, 17913000
. : milestone, 17913000,
profiling (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
tracing (14.522 s) : 14522000, 14522000
. : milestone, 14522000,
section candidate
no_agent (15.34 s) : 15340000, 15340000
. : milestone, 15340000,
appsec (14.641 s) : 14641000, 14641000
. : milestone, 14641000,
iast (18.636 s) : 18636000, 18636000
. : milestone, 18636000,
iast_GLOBAL (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
profiling (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
tracing (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What Does This Do
Propagates the plain response body text as part of the result when the API responds with a non-200 status.
We already include the response body for 200 responses, but previously ignored it for error statuses.
Motivation
Improve observability and debuggability when the Agent returns an error.
Including the response body in error cases provides much more actionable information in tracer logs, especially when debugging protocol or payload issues.
Additional Notes
I discovered this while testing my implementation of the new encoding protocol v1.
My encoded payload contained errors, but the tracer logs only showed a generic message:
After this change, the actual Agent error message is surfaced:
This makes diagnosing payload and protocol issues significantly easier.