Skip to content

[hotfix][mysql][e2e] mysql silent unclassified size copy,table names cannot be capitalized by default. #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlechazoW merged 2 commits into from
Oct 24, 2022
Merged

[hotfix][mysql][e2e] mysql silent unclassified size copy,table names cannot be capitalized by default. #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d66e17
[hotfix][mysql][e2e] mysql silent unclassified size copy,table names …
chaozwn Oct 24, 2022
d2d977c
Merge branch 'master' into e2e-mysql
FlechazoW Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...nnector-mysql/src/main/java/com/dtstack/chunjun/connector/mysql/dialect/MysqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

import org.apache.flink.api.java.tuple.Tuple3;

import org.apache.commons.lang3.StringUtils;

import java.util.Arrays;
import java.util.Optional;
import java.util.function.Function;
Expand Down Expand Up @@ -126,10 +124,6 @@ public Optional<String> getReplaceStatement(

@Override
public Function<JdbcConf, Tuple3<String, String, String>> getTableIdentify() {
return conf ->
Tuple3.of(
null,
StringUtils.upperCase(conf.getSchema()),
StringUtils.upperCase(conf.getTable()));
return conf -> Tuple3.of(conf.getSchema(), null, conf.getTable());
}
}
4 changes: 4 additions & 0 deletions ...-e2e/src/test/java/com/dtstack/chunjun/connector/containers/mysql/MysqlBaseContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package com.dtstack.chunjun.connector.containers.mysql;

import com.github.dockerjava.api.command.CreateContainerCmd;
import org.testcontainers.containers.JdbcDatabaseContainer;
import org.testcontainers.containers.wait.strategy.WaitStrategy;
import org.testcontainers.containers.wait.strategy.WaitStrategyTarget;
Expand All @@ -26,6 +27,7 @@
import java.net.URISyntaxException;
import java.nio.file.Path;
import java.time.Duration;
import java.util.function.Consumer;

public class MysqlBaseContainer extends JdbcDatabaseContainer {

Expand All @@ -40,6 +42,8 @@ public MysqlBaseContainer(String imageName, Path dockerfile) throws URISyntaxExc
withEnv("MYSQL_USER", "admin");
withEnv("MYSQL_PASSWORD", password);
withEnv("MYSQL_ROOT_PASSWORD", password);
withCreateContainerCmdModifier(
(Consumer<CreateContainerCmd>) cmd -> cmd.withCmd("--lower_case_table_names=1"));
withExposedPorts(MYSQL_PORT);
waitingFor(
new WaitStrategy() {
Expand Down