Open
Conversation
![corgea[bot]](https://avatars.githubusercontent.com/in/673913?s=60&v=4){kind=small}
| description: "Tag to publish from (for example: v1.7.2)" | ||
| required: true | ||
| type: string | ||
|
|
Member
There was a problem hiding this comment.
Do we really need a separate npm package for each platform? We could also avoid rebuilding the binaries since we already have a GitHub Action that handles that. Instead, once that workflow completes, we can package all platform-specific binaries into a single npm package and just a have a small logic to resolve the binary path relative to the current js module
Suggested change
| workflow_run: | |
| workflows: ["Native Binary Release"] | |
| types: | |
| - completed |
Ibrahimrahhal
approved these changes
Feb 24, 2026
Member
Ibrahimrahhal
left a comment
Ibrahimrahhal
left a comment
There was a problem hiding this comment.
Left a comment but we can merge it and refactor later if we need it quickly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the CLI binary npm installable. I tried to mock this after how codex packages it's rust binary for npm.
There is a single package that has each platform type as an optional dependency.