Bump dep versions #469
Bump dep versions #469
Conversation
This should have improved Python 3.14 support
|
Warning Rate limit exceeded@msanatan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughRewrote Server installation docs into four options (PyPI, GitHub source, Docker, Local dev); changed examples to use the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideUpdates the server distribution and usage instructions to prefer the published PyPI package and uvx-based invocation, restructures install options (including Docker and local development), and bumps the pydantic dependency with corresponding lockfile changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the first stdio MCP client config example you removed the "type": "stdio" field; if the target MCP clients still require this key for stdio servers, consider restoring it or explicitly calling out when it’s optional.
- The local development instructions now use
uv run src/main.pyinstead of the previousserver.pyentry point; double-check thatsrc/main.pyis the canonical CLI entry and matches how the package is defined inpyproject.tomlto avoid confusion for contributors. - In the Docker section you reference the pre-built image
msanatan/mcp-for-unity-serverbut useunity-mcp-serverfor the locally built image; consider adding a brief note about the differing image names/tags so users don’t assume they must match.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the first stdio MCP client config example you removed the "type": "stdio" field; if the target MCP clients still require this key for stdio servers, consider restoring it or explicitly calling out when it’s optional.
- The local development instructions now use `uv run src/main.py` instead of the previous `server.py` entry point; double-check that `src/main.py` is the canonical CLI entry and matches how the package is defined in `pyproject.toml` to avoid confusion for contributors.
- In the Docker section you reference the pre-built image `msanatan/mcp-for-unity-server` but use `unity-mcp-server` for the locally built image; consider adding a brief note about the differing image names/tags so users don’t assume they must match.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Server/README.md (1)
61-80: Clarify the trade‑offs of using@mainbranch.The Option 2 configuration uses
git+https://github.com/CoplayDev/unity-mcp@main, which installs from the latest unreleased code. While the comment on line 63 correctly describes this as "latest unreleased changes," consider adding a brief warning about the lack of version stability and the potential for breaking changes. Alternatively, if version pinning is preferred, provide a guidance note on using specific commit SHAs or tags.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Server/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
Server/README.md(3 hunks)Server/pyproject.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 468
File: Server/DOCKER_OVERVIEW.md:22-22
Timestamp: 2025-12-19T21:09:35.459Z
Learning: In the Unity MCP project, the Docker workflow (.github/workflows/publish-docker.yml) intentionally uses the DOCKER_USERNAME secret instead of hardcoding "msanatan" to allow users who fork the repository to publish to their own Docker Hub repositories, while the documentation (Server/DOCKER_OVERVIEW.md) correctly references the official image location "msanatan/mcp-for-unity-server" for end users.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Learnt from: JohanHoltby
Repo: CoplayDev/unity-mcp PR: 309
File: MCPForUnity/Editor/Helpers/ServerInstaller.cs:478-508
Timestamp: 2025-10-13T13:41:00.086Z
Learning: In the MCPForUnityTools feature (MCPForUnity/Editor/Helpers/ServerInstaller.cs), the design intentionally forces users to have only one .py file per MCPForUnityTools folder to keep file tracking simple. Package-style tools (subdirectories with __init__.py) are not supported.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to avoid spaces in paths that can cause arg parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path.
📚 Learning: 2025-09-05T16:22:04.960Z
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Applied to files:
Server/README.md
📚 Learning: 2025-09-05T16:22:04.960Z
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to avoid spaces in paths that can cause arg parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path.
Applied to files:
Server/README.md
📚 Learning: 2025-10-13T13:41:00.086Z
Learnt from: JohanHoltby
Repo: CoplayDev/unity-mcp PR: 309
File: MCPForUnity/Editor/Helpers/ServerInstaller.cs:478-508
Timestamp: 2025-10-13T13:41:00.086Z
Learning: In the MCPForUnityTools feature (MCPForUnity/Editor/Helpers/ServerInstaller.cs), the design intentionally forces users to have only one .py file per MCPForUnityTools folder to keep file tracking simple. Package-style tools (subdirectories with __init__.py) are not supported.
Applied to files:
Server/README.md
📚 Learning: 2025-12-19T21:09:35.459Z
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 468
File: Server/DOCKER_OVERVIEW.md:22-22
Timestamp: 2025-12-19T21:09:35.459Z
Learning: In the Unity MCP project, the Docker workflow (.github/workflows/publish-docker.yml) intentionally uses the DOCKER_USERNAME secret instead of hardcoding "msanatan" to allow users who fork the repository to publish to their own Docker Hub repositories, while the documentation (Server/DOCKER_OVERVIEW.md) correctly references the official image location "msanatan/mcp-for-unity-server" for end users.
Applied to files:
Server/README.md
📚 Learning: 2025-11-27T21:09:35.011Z
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 401
File: MCPForUnity/Editor/Clients/Configurators/VSCodeConfigurator.cs:10-18
Timestamp: 2025-11-27T21:09:35.011Z
Learning: VS Code GitHub Copilot MCP configuration supports mcp.json files placed directly in the Code/User directory: %APPDATA%\Code\User\mcp.json on Windows, ~/Library/Application Support/Code/User/mcp.json on macOS, and ~/.config/Code/User/mcp.json on Linux. This is in addition to workspace-scoped .vscode/mcp.json files.
Applied to files:
Server/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Sourcery review
🔇 Additional comments (5)
Server/pyproject.toml (1)
35-35: Pydantic 2.12.5 is a stable patch release with no known security advisories.Pydantic 2.12.5 is documented and available. This is the final 2.12 release, and the fourth 2.12 patch release, fixing more regressions and an issue with the serialization of IP address types when serialize_as_any is used. The known CVE affecting pydantic (CVE-2024-3772) targets versions below 2.4.0, so 2.12.5 is unaffected. No additional security concerns were identified for this version.
Server/README.md (4)
82-93: Option 3 local development setup is clear and well-structured.The local development instructions correctly distinguish between
uv run(for source) anduvx(for installed packages), and the subprocess example (uv run src/main.py --transport stdio) is appropriately configured for MCP client integration.
95-110: Docker option is well-documented and correctly configured.The Docker section correctly references the official image location (
msanatan/mcp-for-unity-server) for end users while providing local build instructions. The port mapping and HTTP configuration are appropriate. Aligns with established project practices for Docker documentation.
1-110: The PR scope is correctly aligned. The dependency fileServer/pyproject.tomlcontaining the pydantic version bump (to 2.12.5) is part of this PR, matching the title "Bump dep versions." The README.md documentation changes shown are from the same commit. No scope mismatch exists.Likely an incorrect or invalid review comment.
14-14: Replace all references to "mcpforunityserver" with the correct installation method and command name.Lines 27 and 51 incorrectly reference
"mcpforunityserver"as a PyPI package. The server is not published to PyPI; instead, useuvx --from "git+https://github.com/CoplayDev/[email protected]#subdirectory=Server" mcp-for-unity. The entry point command ismcp-for-unity, notmcpforunityserver. The HTTP endpoint configuration ("url": "http://localhost:8080/mcp") is correct.⛔ Skipped due to learnings
Learnt from: dsarno Repo: CoplayDev/unity-mcp PR: 265 File: README.md:204-204 Timestamp: 2025-09-05T16:22:04.960Z Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to avoid spaces in paths that can cause arg parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path.Learnt from: dsarno Repo: CoplayDev/unity-mcp PR: 265 File: README.md:204-204 Timestamp: 2025-09-05T16:22:04.960Z Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.Learnt from: dsarno Repo: CoplayDev/unity-mcp PR: 265 File: README.md:204-204 Timestamp: 2025-09-05T16:22:04.960Z Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.Learnt from: msanatan Repo: CoplayDev/unity-mcp PR: 316 File: TestProjects/UnityMCPTests/Assets/Tests/EditMode/Resources.meta:1-8 Timestamp: 2025-10-13T13:27:23.040Z Learning: UnityMcpBridge is a legacy project kept for backwards compatibility; MCPForUnity is the only active Unity plugin project. GUID collisions between UnityMcpBridge and MCPForUnity are acceptable.Learnt from: JohanHoltby Repo: CoplayDev/unity-mcp PR: 309 File: MCPForUnity/Editor/Helpers/ServerInstaller.cs:478-508 Timestamp: 2025-10-13T13:41:00.086Z Learning: In the MCPForUnityTools feature (MCPForUnity/Editor/Helpers/ServerInstaller.cs), the design intentionally forces users to have only one .py file per MCPForUnityTools folder to keep file tracking simple. Package-style tools (subdirectories with __init__.py) are not supported.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Server/README.md (1)
61-80: Resolve version tag mismatch with "latest unreleased" description.Line 63 states this option is for running "the latest unreleased changes from the repository," but Line 72 specifies a version tag (
@v8.2.3). Version tags reference released code from that point, not unreleased/main-branch changes. Use@main(or another appropriate branch) to reflect the documented intent of running unreleased changes.🔎 Proposed fix
- "git+https://github.com/CoplayDev/[email protected]#subdirectory=Server", + "git+https://github.com/CoplayDev/unity-mcp@main#subdirectory=Server",
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Server/README.md(3 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: JohanHoltby
Repo: CoplayDev/unity-mcp PR: 309
File: MCPForUnity/Editor/Helpers/ServerInstaller.cs:478-508
Timestamp: 2025-10-13T13:41:00.086Z
Learning: In the MCPForUnityTools feature (MCPForUnity/Editor/Helpers/ServerInstaller.cs), the design intentionally forces users to have only one .py file per MCPForUnityTools folder to keep file tracking simple. Package-style tools (subdirectories with __init__.py) are not supported.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to avoid spaces in paths that can cause arg parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path.
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 468
File: Server/DOCKER_OVERVIEW.md:22-22
Timestamp: 2025-12-19T21:09:35.459Z
Learning: In the Unity MCP project, the Docker workflow (.github/workflows/publish-docker.yml) intentionally uses the DOCKER_USERNAME secret instead of hardcoding "msanatan" to allow users who fork the repository to publish to their own Docker Hub repositories, while the documentation (Server/DOCKER_OVERVIEW.md) correctly references the official image location "msanatan/mcp-for-unity-server" for end users.
📚 Learning: 2025-09-05T16:22:04.960Z
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to mitigate argument parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path with spaces.
Applied to files:
Server/README.md
📚 Learning: 2025-09-05T16:22:04.960Z
Learnt from: dsarno
Repo: CoplayDev/unity-mcp PR: 265
File: README.md:204-204
Timestamp: 2025-09-05T16:22:04.960Z
Learning: In the Unity MCP project, the ServerInstaller.cs creates a symlink from ~/Library/AppSupport to ~/Library/Application Support on macOS to avoid spaces in paths that can cause arg parsing and quoting issues in some MCP clients. The README documentation should use the shortened AppSupport path, not the full "Application Support" path.
Applied to files:
Server/README.md
📚 Learning: 2025-10-13T13:41:00.086Z
Learnt from: JohanHoltby
Repo: CoplayDev/unity-mcp PR: 309
File: MCPForUnity/Editor/Helpers/ServerInstaller.cs:478-508
Timestamp: 2025-10-13T13:41:00.086Z
Learning: In the MCPForUnityTools feature (MCPForUnity/Editor/Helpers/ServerInstaller.cs), the design intentionally forces users to have only one .py file per MCPForUnityTools folder to keep file tracking simple. Package-style tools (subdirectories with __init__.py) are not supported.
Applied to files:
Server/README.md
📚 Learning: 2025-12-19T21:09:35.459Z
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 468
File: Server/DOCKER_OVERVIEW.md:22-22
Timestamp: 2025-12-19T21:09:35.459Z
Learning: In the Unity MCP project, the Docker workflow (.github/workflows/publish-docker.yml) intentionally uses the DOCKER_USERNAME secret instead of hardcoding "msanatan" to allow users who fork the repository to publish to their own Docker Hub repositories, while the documentation (Server/DOCKER_OVERVIEW.md) correctly references the official image location "msanatan/mcp-for-unity-server" for end users.
Applied to files:
Server/README.md
📚 Learning: 2025-11-27T21:09:35.011Z
Learnt from: msanatan
Repo: CoplayDev/unity-mcp PR: 401
File: MCPForUnity/Editor/Clients/Configurators/VSCodeConfigurator.cs:10-18
Timestamp: 2025-11-27T21:09:35.011Z
Learning: VS Code GitHub Copilot MCP configuration supports mcp.json files placed directly in the Code/User directory: %APPDATA%\Code\User\mcp.json on Windows, ~/Library/Application Support/Code/User/mcp.json on macOS, and ~/.config/Code/User/mcp.json on Linux. This is in addition to workspace-scoped .vscode/mcp.json files.
Applied to files:
Server/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Sourcery review
🔇 Additional comments (5)
Server/README.md (5)
14-14: Prerequisites section accurately reflects uvx/uv requirement.Clear setup of expectations for users installing from PyPI and running the server.
20-59: Verify PyPI package name consistency.The Option 1 documentation uses
mcpforunityserverin theuvx --fromargument. Please confirm this matches the actual PyPI package identifier. Most PyPI packages use hyphens (e.g.,mcp-for-unity-server), so verify the package name and command alias are correctly paired for uvx.
82-98: Docker section is well-structured.Pre-built and local build examples are clear. Image naming aligns with the published Docker Hub repository. HTTP configuration and port usage are consistent with other installation options.
99-110: Local development option is correct.Using
uv run src/main.pywith stdio transport is appropriate for local development and testing workflows.
145-150: Requirements section correctly updated.Adding
uvas an explicit requirement alongside Python and Unity versions sets clear expectations. Installation guide link is helpful.
1 participant
Should help address #454
Summary by Sourcery
Update server dependency versions and refresh installation and usage instructions for multiple deployment options.
New Features:
Enhancements:
Documentation:
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.