Custom Error Pages#200
Merged
mxmeinhold merged 7 commits intoComputerScienceHouse:developfrom Mar 9, 2020
Merged
Conversation
…/develop Packet 3.3 - Fall Packet MVP
…/develop Version 3.3.1
…/develop Version 3.3.2
…/develop Version 3.3.3
mxmeinhold
approved these changes
Mar 9, 2020
Collaborator
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
LGTM! 🚢 🙌
Only comment is this looks like it’s merging master into develop as well. I think that’s fine, but if you want to maintain the same pattern we’ve had I’d cherry pick or rebase onto develop.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
Adds error pages for 500 and 404 errors. Still sends errors to sentry.
This allows users to still have access to the toolbar so they can tab back to where they need to be easily