Merged
Conversation
mxmeinhold
force-pushed
the
apply-routes
branch
from
c27cd12 to
32d9144
Compare
JoelEager
approved these changes
Oct 30, 2019
Member
JoelEager
left a comment
JoelEager
left a comment
There was a problem hiding this comment.
Looks good to me. Though in the future we may want to support batch creation of packets since that would be the "normal" use case.
Collaborator
Author
|
I think handling the payload as a list is best, so I'd like to get that in before this get merged. |
mxmeinhold
force-pushed
the
apply-routes
branch
from
b9b51b0 to
5db794d
Compare
mxmeinhold
force-pushed
the
apply-routes
branch
from
5db794d to
d1796b8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New routes to sync freshman and to create packets in order to facilitate apply.csh
Closes #178