Using freshmen gravatar images#166
Merged
devinmatte merged 3 commits intoComputerScienceHouse:developfrom Aug 27, 2019
Merged
Conversation
JoelEager
approved these changes
Aug 25, 2019
Member
JoelEager
left a comment
JoelEager
left a comment
There was a problem hiding this comment.
Looks good but I have a couple of minor comments.
|
|
||
|
|
||
| @lru_cache(maxsize=128) | ||
| def get_rit_image(username): |
Member
There was a problem hiding this comment.
Maybe it'd make more sense to call this get_gravatar() instead? It's not pulling the image from any RIT service so it's not really an "RIT image".
Member
Author
There was a problem hiding this comment.
I'm planning to get more than just gravatar in the future, but it will be based on the RIT email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to allow freshmen to use gravatar images if they want, check if they have one and display it