Send an email when the packet is generated#145
Merged
devinmatte merged 3 commits intoComputerScienceHouse:developfrom Aug 10, 2019
Merged
Send an email when the packet is generated#145devinmatte merged 3 commits intoComputerScienceHouse:developfrom
devinmatte merged 3 commits intoComputerScienceHouse:developfrom
Conversation
mxmeinhold
previously requested changes
Aug 10, 2019
Collaborator
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
One duplicate env var And a few questions.
JoelEager
approved these changes
Aug 10, 2019
Member
JoelEager
left a comment
JoelEager
left a comment
There was a problem hiding this comment.
The only real comment I have is the date thing and that I can go either way on so feel free to take it or leave it. Other than that it looks good to me.
On a non-code note, are we sticking with giving creds in person? That section of the email didn't quite make sense to me so I was curious what the plan was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a packet is generated the freshman will be emailed with the start date and time, a link to visit freshmen-packet.csh.rit.edu, an email for evals and rtps