Fixed ArgumentOutOfRangeException in AdvancedCollectionView

[w-ahmad]

Fixes #4339

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• New component
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • If control, added to Visual Studio Design project
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

[ghost]

Thanks w-libs for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[XAML-Knight]

PR approved. Unfortunately, the issues in #4263 and #2913 still persist, even with this fix applied.

[w-ahmad]

PR approved. Unfortunately, the issues in #4263 and #2913 still persist, even with this fix applied.

Thanks @XAML-Knight, These issues are not related to AdvancedCollectionView. If you try to use CollectionViewSource, same error will happen again. So the problem is within DataGrid at line 957, where we are trying to get removed item from collection but item is not exist.

[w-ahmad]

I have opened a PR #4360 for these issues with a possible solution.

PR approved. Unfortunately, the issues in #4263 and #2913 still persist, even with this fix applied.

[michael-hawker]

Definitely worried about the performance impact here, this seems like a lot of extra work and memory to determine this calculation.

[w-ahmad]

Yes it could impact on performance, but not sure about any other possible solutions right now. Someone should have to run benchmark stuff on this method to get a better overview.

[michael-hawker]

If the unit test you added shows the failure case at least, then it'd be good if we can figure out how to fix the original algorithm here. We wouldn't want to add extra overhead to this helper.

This class is relatively isolated, so you may be able to pull it out to run benchmarking on it in isolation vs. trying to add benchmarking within the project. @Sergio0694 any tips/resources/articles to point @w-ahmad to for benchmarking code like this?