Fixed generated properties within regions#4227
Merged
2 commits merged intoCommunityToolkit:mainfrom Sep 16, 2021
Merged
Conversation
michael-hawker
approved these changes
Sep 7, 2021
Rosuavio
approved these changes
Sep 16, 2021
|
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4225
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Compilation fails If the Microsoft MVVM Toolkit source generator attribute
[ObservableProperty]is in a#regionblock.What is the new behavior?
The generated code is now correct when regions are used.
PR Checklist
Please check if your PR fulfills the following requirements: