Controls.Media update winui version#4157
Merged
michael-hawker merged 1 commit intoCommunityToolkit:mainfrom Aug 3, 2021
Rosuavio:winui2.6-missed
Merged
Controls.Media update winui version#4157michael-hawker merged 1 commit intoCommunityToolkit:mainfrom Rosuavio:winui2.6-missed
michael-hawker merged 1 commit intoCommunityToolkit:mainfrom
Rosuavio:winui2.6-missed
Conversation
|
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Member
|
Thanks @RosarioPulella. I know we already tested these controls as part of the Sample App with the change, so this should just be a build issue to ensure they're being used when the package is alone. So don't expect any problems here once the build is done. 🙂 |
michael-hawker
approved these changes
Aug 3, 2021
Contributor
|
I think the build will fail. Since, we don't yet have the Design project for media controls. I'll add the Design project in #3794, which will make this change work. But for now, just update the WinUI version without the import. |
Contributor
Author
|
Thanks @Nirmal4G, update accordingly. |
XAML-Knight
approved these changes
Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Update winui version
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Microsoft.Toolkit.Uwp.UI.Controls.Mediauses winui 2.5What is the new behavior?
Microsoft.Toolkit.Uwp.UI.Controls.Mediauses winui 2.6.1PR Checklist
Please check if your PR fulfills the following requirements:
Other information