Updated WinUI package to min 17763, update WinAppSdk to 1.1.4#24
Closed
Arlodotexe wants to merge 3 commits intoCommunityToolkit:mainfrom
Closed
Updated WinUI package to min 17763, update WinAppSdk to 1.1.4#24Arlodotexe wants to merge 3 commits intoCommunityToolkit:mainfrom
Arlodotexe wants to merge 3 commits intoCommunityToolkit:mainfrom
Conversation
Member
|
@Arlodotexe forgot you mentioned you were making this PR, I also made some updates in #20 as some general clean-up. I think you missed a couple of other spots. We can pull that out of mine and into yours though. As it also seems there may be some general build clean-up we need to do. |
Member
|
Even on the main build we're failing, so there's some other tweak we need: @Arlodotexe want to pull in commits c4fec71 953d509 4ab07cd a48d4cd (all but the license change from my other PR) here, and then see what happens when you run the build.bat locally? And see what else we need to tweak? |
Member
|
Moved to #26, going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the TargetFramework for the WinUI package to
net5.0-windows10.0.17763.0, the minimum LTS version supported by the WinAppSDK.It also updates the
Microsoft.WindowsAppSDKpackage to 1.1.4.