This repository was archived by the owner on Jun 8, 2022. It is now read-only.
Open
Conversation
Owner
|
This looks great so far :) I am gonna throw in some try/except for imports and then it should be good to go Ambient has the same issues on my windows machine but I guess the point of this MR is linux support so I am gonna merge it anyways |
Owner
|
Make any adjustments you want to that and let me know when you think it is ready Then I can test and merge if it is working as it should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
running OpenRGB under Ubuntu I found the missing screen capture support in Ambient.py quite annoying (since the remaining scripts perform well under Linux) and patched together a workaround.
319d633 uses X11 to get the PIL Image from the current screen, but for performance reasons it requires compiling some C code on the machine beforehand (all credit goes to https://stackoverflow.com/questions/69645/take-a-screenshot-via-a-python-script-on-linux). Having the compiled program, Ambient.py runs very well on my machine.
I also played around using k-means clustering instead of just the average RGB value to determine the LED-setting (fd8ea3a). This is somewhat experimental as it required smoothing out the colors over multiple frames (in this case 3) to prevent flickering due to sampling differences. It works well for me for gaming but it requires scikit-learn for clustering and is not tested on Win or Mac.
Hope you find something oft his useful.
Cheers