Removed the use statement to not make static analysis trip over#19
Merged
TavoNiievez merged 1 commit intoCodeception:masterfrom Dec 18, 2021
Rockylars:remove_use_statement
Merged
Removed the use statement to not make static analysis trip over#19TavoNiievez merged 1 commit intoCodeception:masterfrom Rockylars:remove_use_statement
TavoNiievez merged 1 commit intoCodeception:masterfrom
Rockylars:remove_use_statement
Conversation
TavoNiievez
approved these changes
Dec 18, 2021
Member
TavoNiievez
left a comment
TavoNiievez
left a comment
There was a problem hiding this comment.
@Rockylars thanks, and sorry for reintroducing that issue
Contributor
Author
Its alright, there's a few other methods in our _generated context that suffer from the same problem. One day this'll be resolved, but our baseline currently takes care of the issue of the original ones. I would recommend that you guys check out the other Codeception extensions to see if they too create the same problem. PHPStan users will thank you 😉 |
Member
|
@Rockylars if you tell me in detail how to do this check I could do it in all of Codeception. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Hey there, this is the exact same fix as #9, related to #13, you can check the issue ticket to see what this is about.