Temporarily remove LanguageClient dependency#18
Merged
austincondiff merged 3 commits intomainfrom Jan 29, 2024
Merged
Conversation
Contributor
|
SwiftLint is failing, is this temporary too or can you fix this? |
tom-ludwig
previously requested changes
Jan 28, 2024
Member
tom-ludwig
left a comment
tom-ludwig
left a comment
There was a problem hiding this comment.
Just pop in those spaces between slashes and code, and you're good to go 👍🏻
Sources/CodeEditKit/NonUIExtensions/LSP/LanguageExtension.swift
Outdated
Show resolved
Hide resolved
Member
|
Instead of commenting out the code, I would just remove it alltogether, as it's not working, and probably out of date. The code is also from ChimeKit, and I should have referenced that. |
Member
Author
|
Fixed! |
Wouter01
approved these changes
Jan 28, 2024
tom-ludwig
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the LanguageClient and ProcessService dependency from this library so that it can be added and updated within the main CodeEdit repo instead. This is just temporary to allow the LSP code to exist and be updated without relying on CodeEditKit's version.
Related Issues
Closes #17
Checklist