-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add memory profiling support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
55eeef1 to
4bd794f
Compare
2351156 to
c6a08d7
Compare
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
.github/workflows/codspeed.yml
Outdated
| - name: Run benchmarks | ||
| uses: CodSpeedHQ/action@main | ||
| with: | ||
| runner-version: branch:cod-2105-support-memory-profiling-for-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not forget to drop this commit
| sudo apt-get install valgrind -y | ||
| uv sync --dev | ||
| sudo apt-get remove valgrind -y | ||
| - uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant to request changes
Especially we need to validate the extra stack frame thing in instrumentation by comparing the output to a real prod run!
1f5d7cf to
e15aad8
Compare
Merging this PR will degrade performance by 16.62%
Performance Changes
Comparing |
504d9a3 to
373acb4
Compare
373acb4 to
fc8f559
Compare
No description provided.