This repository was archived by the owner on Oct 23, 2020. It is now read-only.
Allow the setting of custom typefaces for FloatingActionMenu#223
Merged
Clans merged 1 commit intoClans:masterfrom May 24, 2016
Merged
Allow the setting of custom typefaces for FloatingActionMenu#223Clans merged 1 commit intoClans:masterfrom
Clans merged 1 commit intoClans:masterfrom
Conversation
| String customFont = attr.getString(R.styleable.FloatingActionMenu_menu_labels_customFont); | ||
| try { | ||
| if (!TextUtils.isEmpty(customFont)) { | ||
| mCustomTypefaceFromFont = Typeface.createFromAsset(getContext().getAssets(), String.format("%s", customFont)); |
There was a problem hiding this comment.
Why String.format? I'm afraid of localization issues
|
👍 otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throws exception if font fails to load.