Open
Conversation
Add the Java compiler option to enable the recommended compiler warnings to the gradle and maven builds.
The test classes in ocpp-v1_6-test rely heavily on using deprecated constructors and unchecked type casts, so suppress the warnings.
Some ocpp-v1_6 tests rely heavily on the deprecated no-arg constructors, so just suppress the deprecation warnings for them.
The ChangeAvailabilityConfirmation() constructor was marked deprecated in the Javadoc, but missing the annotation. Add the missing annotation.
Contributor
Author
|
@TVolden could you maybe spare some time to look over this PR as well? This is a "cleanup" PR to fix the annoying compiler warnings that were shown on every build. |
TVolden
approved these changes
Mar 22, 2026
Member
TVolden
left a comment
TVolden
left a comment
There was a problem hiding this comment.
Everything looks good. Good job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy code produced a number of compiler warnings when building,
which might distract from actual issues being introduced.
Enable all recommended warnings when building and address all compiler
warnings, mostly with a real fix, and suppress warnings in select cases
where a fix is not feasible, so that the library compiles without any
warnings.