run_lang2sql 단에서 파라미터 받아올 수 있도록 수정#197
Merged
Conversation
Collaborator
|
👍 @HWALIMLEE 기여 감사합니다!
추가로 default값으로 넣게되면 함수 정의 시점에 평가되어서 session_state가 업데이트 되어도 반영되지 않을듯 합니다. print("--------------------------------")
print(f"use_enriched_graph: {use_enriched_graph}")
print(st.session_state.get("use_enriched", False))
print("--------------------------------")--------------------------------
use_enriched_graph: False
True
--------------------------------💊 streamlit의 ❗Black 을 통해서 포매팅 부탁드립니다! 💬 리뷰를 위해 살피다 보니 코드가 복잡하기는 하네요...! 변수명도 그렇고 정비의 필요성을 여전히 느낍니다! |
Contributor
Author
|
아 저걸 체크하고 돌리는 걸 깜빡했군요..! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#️⃣ Issue Number
📝 요약(Summary)
💬 To Reviewers (선택)
PR Checklist
reference) How to Code Review