Skip to content

tweak: adjust disabled colors for gray variant #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ameer2468 merged 1 commit into from
Sep 1, 2025
Merged

tweak: adjust disabled colors for gray variant #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ export function CustomDomain() {
Custom Domain
</h1>
<p className="w-full text-sm text-gray-10">
Set up a custom domain for your organization's shared caps.
Setup a custom domain for your organization's shared caps.
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammar: use “Set up” (verb), not “Setup”.

Apply:

-                Setup a custom domain for your organization's shared caps.
+                Set up a custom domain for your organization's shared caps.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Setup a custom domain for your organization's shared caps.
Set up a custom domain for your organization's shared caps.
🤖 Prompt for AI Agents 
In
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
around line 97, the displayed sentence uses the noun "Setup" but should use the
verb phrase "Set up"; update the string literal to "Set up a custom domain for
your organization's shared caps." so the grammar is correct and rebuild to
verify the UI text updates.

</p>
</div>
</div>
<div className="flex flex-1 gap-2 justify-between items-center w-full">
<div className="flex gap-2 justify-between items-center px-3 flex-1 h-[44px] rounded-xl border bg-gray-2 border-gray-3">
<p className="text-[13px] text-gray-10">
{orgCustomDomain || "No custom domain"}
<p className="text-[13px] text-gray-8">
{orgCustomDomain || "No custom domain has been setup"}
</p>
Comment on lines +103 to 105
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammar in fallback text.

Use “set up” (verb) and a period.

-              <p className="text-[13px] text-gray-8">
-                {orgCustomDomain || "No custom domain has been setup"}
+              <p className="text-[13px] text-gray-8">
+                {orgCustomDomain || "No custom domain has been set up."}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<p className="text-[13px] text-gray-8">
{orgCustomDomain || "No custom domain has been setup"}
</p>
<p className="text-[13px] text-gray-8">
{orgCustomDomain || "No custom domain has been set up."}
</p>
🤖 Prompt for AI Agents 
In
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
around lines 103 to 105, the fallback text "No custom domain has been setup" has
incorrect grammar and missing punctuation; change the displayed string to use
the verb form and add a period, e.g., "No custom domain has been set up." so the
JSX renders the corrected sentence.

<div className="flex items-center">
{orgCustomDomain && isVerified ? (
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const buttonVariants = cva(
white:
"bg-gray-1 border border-gray-6 text-gray-12 hover:bg-gray-3 disabled:bg-gray-8",
ghost: "hover:bg-white/20 hover:text-white",
gray: "bg-gray-5 hover:bg-gray-7 border border-gray-6 gray-button-shadow text-gray-12 disabled:bg-gray-8 disabled:text-gray-9",
gray: "bg-gray-5 hover:bg-gray-7 border border-gray-6 gray-button-shadow text-gray-12 disabled:border-gray-7 disabled:bg-gray-8 disabled:text-gray-11",
dark: "bg-gray-12 dark-button-shadow hover:bg-gray-11 border border-gray-12 text-gray-1 disabled:cursor-not-allowed disabled:text-gray-10 disabled:bg-gray-7 disabled:border-gray-8",
darkgradient:
"bg-gradient-to-t button-gradient-border from-[#0f0f0f] to-[#404040] shadow-[0_0_0_1px] hover:brightness-110 shadow-[#383838] text-gray-50 hover:bg-[#383838] disabled:bg-[#383838] border-transparent",
Expand Down
Loading