Camera feed actor#946
Merged
oscartbeaumont merged 5 commits intooverhaul-camera-previewfrom Aug 25, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
ebb28ec
into
overhaul-camera-preview
8 of 11 checks passed
Brendonovich
added a commit
that referenced
this pull request
Aug 26, 2025
* texture builder abstraction * rip out loading state for now * init fallback texture on startup * overhaul * rename camera feed * clippy * Camera feed actor (#946) * wip * vibe code it * wip * make recording work * handle InputConnected in connecting Lock --------- Co-authored-by: Brendan Allan <brendonovich@outlook.com> * wip * loading state + fix camera feed by cleanup up channel handling * wip * fix camera preview height strech * format * Clippy * fix * allow disabling countdown * unlock feeds via channel instead of blocking * fix camera feed on windows * reverse header on macos --------- Co-authored-by: Brendan Allan <brendonovich@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.