Skip to content

Fix: auto-set padding when background is selected #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 5 commits into from
Aug 21, 2025
Merged

Fix: auto-set padding when background is selected #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d01753
Fix: auto-set padding when background is selected
Enejivk Aug 15, 2025
abde7fe
Revert formatting changes to tauri.ts and auto-imports.d.ts
Enejivk Aug 15, 2025
20996da
Merge branch 'main' into fix-editor-padding
oscartbeaumont Aug 20, 2025
106f30e
format
oscartbeaumont Aug 20, 2025
f9241ce
cleanup
Brendonovich Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/desktop/src/routes/editor/ConfigSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,12 @@ function BackgroundConfig(props: { scrollRef: HTMLDivElement }) {
}));
});

// set padding if background is selected
const ensurePaddingForBackground = () => {
if (project.background.padding === 0)
setProject("background", "padding", 10);
};

// Validate background source path on mount
onMount(async () => {
if (
Expand Down Expand Up @@ -784,6 +790,7 @@ function BackgroundConfig(props: { scrollRef: HTMLDivElement }) {
value={project.background.source.type}
onChange={(v) => {
const tab = v as BackgroundSource["type"];
ensurePaddingForBackground();
switch (tab) {
case "image": {
setProject("background", "source", {
Expand Down Expand Up @@ -1017,6 +1024,8 @@ function BackgroundConfig(props: { scrollRef: HTMLDivElement }) {
// Get the raw path without any URL prefixes

debouncedSetProject(wallpaper.rawPath);

ensurePaddingForBackground();
} catch (err) {
toast.error("Failed to set wallpaper");
}
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/utils/createPresets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function createPresets() {
query,
createPreset: async (preset: CreatePreset) => {
const config = { ...preset.config };
// @ts-ignore we reeeally don't want the timeline in the preset
// @ts-expect-error we reeeally don't want the timeline in the preset
Copy link
Contributor

@oscartbeaumont oscartbeaumont Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by Biome automatically. Although it's outside of the changes on this PR gonna keep it.

config.timeline = undefined;

await updatePresets((store) => {
Expand Down
Loading