Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces two new screen capture crates (scap-direct3d for Windows, scap-screencapturekit for macOS) and a cross-platform FFmpeg bridge (scap-ffmpeg) with examples. Centralizes futures via workspace. Adjusts Windows dependencies to workspace/targets. Makes Biome lint non-blocking. Minor manifest tweaks and whitespace edits. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant Display (Win)
participant Capturer (D3D)
participant Callback
participant FFmpeg
App->>Display (Win): primary()
App->>Capturer (D3D): new(item, settings).start(cb)
Capturer (D3D)->>Capturer (D3D): init D3D11 + frame pool
loop until stopped
Capturer (D3D)->>Callback: on_frame(Frame)
Callback->>FFmpeg: Frame.as_ffmpeg()
FFmpeg-->>Callback: Video frame
end
App->>Capturer (D3D): stop()
sequenceDiagram
participant App
participant Targets (macOS)
participant StreamCfgBuilder
participant Capturer (SCKit)
participant Callback
participant FFmpeg
App->>Targets (macOS): Display::primary()
App->>StreamCfgBuilder: with_fps/size/cursor.build()
App->>Capturer (SCKit): builder(target,cfg).with_callbacks().build()
App->>Capturer (SCKit): start()
loop until stop
Capturer (SCKit)->>Callback: did_output(Frame::Screen)
Callback->>FFmpeg: VideoFrame.as_ffmpeg()
FFmpeg-->>Callback: Video frame
end
App->>Capturer (SCKit): stop()
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (28)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 22, 2025
Merged
1 task
This was referenced Sep 30, 2025
This was referenced Nov 3, 2025
Merged
This was referenced Nov 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few framework-specific crates for rebuilding Scap on top of:
scap-screencapturekitfor macOSscap-direct3dfor Windows (D3D11 and probably older versions i need to investigate)scap-ffmpegfor maximum efficiency conversions from native buffers toffmpeg::frame::VideoAll these crates focus on providing as much native access as possible with minimal data copying.
Much of the windows code has been adapted from https://github.com/NiiightmareXD/windows-capture
Summary by CodeRabbit
New Features
Chores
Documentation
Style