improvement: Confirm remove domain dialog#871
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughUpdates ConfirmationDialog prop type to replace "secondary" with "outline". Refactors CustomDomain removal to use a ConfirmationDialog instead of window.confirm, adds dialog state management, tooltips, icons, and integrates loading/cleanup, while preserving subscription gating and success/error toasts with refresh. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CD as CustomDomain component
participant D as ConfirmationDialog
participant S as Subscription/Env Checks
participant API as Remove Domain API
participant UI as Toast/Router
U->>CD: Click Remove (verified domain)
CD->>D: Open confirmation dialog
D-->>U: Show dialog (icon + description)
U->>D: Confirm
D->>CD: onConfirm
CD->>S: Validate subscribed / not dev
alt Allowed
CD->>API: removeDomain(orgCustomDomain)
API-->>CD: Success/Failure
alt Success
CD->>UI: Show success toast + refresh
else Failure
CD->>UI: Show error toast
end
else Blocked
CD->>UI: Show upgrade/modal notice
end
CD->>D: Close dialog (reset state)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 12, 2025
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Summary by CodeRabbit
New Features
Style
UX Improvements