web: fix render condition of summary

[ameer2468]

Summary by CodeRabbit

• Refactor
  • Improved premium feature access control for AI-generated video summaries. Access is now consistently enforced based on subscription status, with streamlined logic for blocking non-Pro users.

[coderabbitai]

Walkthrough

The Summary tab's access-control logic for non-owners was simplified by removing a secondary guard that checked for existing AI data (summary or chapters). Non-owners are now blocked solely based on the isVideoOwnerPro flag, while owners continue to see the AI data UI as before.

Changes

Cohort / File(s)	Summary
Pro-access Gating Simplification apps/web/app/s/[videoId]/_components/tabs/Summary.tsx	Removed the additional guard that required existing AI data for non-owners; access control now determined solely by isVideoOwnerPro flag

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• PR web: fix video owner pro check #1241: Directly modifies Summary tab's pro-access gating to use isVideoOwnerPro, rewriting previous guards around existing AI data.
• PR chore: improve the resilience of checking #1242: Alters the computation of isVideoOwnerPro/isOwner, which directly impacts the access-control guard simplified in this PR.

Poem

🐰 A rabbit hops through gates so clean,
No extra checks to intervene—
Just pro-flag guards, simple and bright,
The Summary tab now gates just right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “web: fix render condition of summary” accurately captures the core change of this pull request, which updates the rendering logic for the summary component in the web app. It is concise and clearly refers to modifying the render condition without extraneous details or vague language. The prefix “web:” appropriately signals the scope of the change, and the phrasing “fix render condition” directly reflects the adjustments described in the summary. This makes it easy for readers to understand the primary purpose of the PR at a glance.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-cap-ai-summary-condition

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7468355 and ac57ad1.

📒 Files selected for processing (1)

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use a 2-space indent for TypeScript code.
Use Biome for formatting and linting TypeScript/JavaScript files by running pnpm format.

Use strict TypeScript and avoid any; leverage shared types

Files:

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx}: Use kebab-case for filenames for TypeScript/JavaScript modules (e.g., user-menu.tsx).
Use PascalCase for React/Solid components.

Files:

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx

apps/web/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

On the client, always use useEffectQuery or useEffectMutation from @/lib/EffectRuntime; never call EffectRuntime.run* directly in components.

Files:

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TanStack Query v5 for all client-side server state and fetching in the web app
Mutations should call Server Actions directly and perform targeted cache updates with setQueryData/setQueriesData
Run server-side effects via the ManagedRuntime from apps/web/lib/server.ts using EffectRuntime.runPromise/runPromiseExit; do not create runtimes ad hoc
Client code should use helpers from apps/web/lib/EffectRuntime.ts (useEffectQuery, useEffectMutation, useRpcClient); never call ManagedRuntime.make inside components

Files:

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx

apps/web/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Server components needing Effect services must call EffectRuntime.runPromise(effect.pipe(provideOptionalAuth))

Files:

• apps/web/app/s/[videoId]/_components/tabs/Summary.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
• GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
• GitHub Check: Analyze (rust)
• GitHub Check: Analyze (javascript-typescript)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}